Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Journey challenges navbar #145

Merged
merged 8 commits into from
Feb 7, 2024
Merged

Journey challenges navbar #145

merged 8 commits into from
Feb 7, 2024

Conversation

cgu2020
Copy link
Contributor

@cgu2020 cgu2020 commented Nov 16, 2023

Summary

This pull request is the first step towards implementing Top Navbar on the homepage

  • implemented Navbar
  • Added fonts to project
  • Default font and color added to main
Screenshot 2023-11-29 at 6 15 11 PM

@dti-github-bot
Copy link
Member

dti-github-bot commented Nov 16, 2023

[diff-counting] Significant lines: 89.

tuckerstanley
tuckerstanley previously approved these changes Nov 30, 2023
Copy link
Contributor

@tuckerstanley tuckerstanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran this on my emulator. The navbar works as expected, and looks good! Great work. Now that leaderboard PR is merged make sure you resolve those conflicts.

@BrianLa0616
Copy link
Contributor

Other than geolocator not working, great work! The animation is really nice and clean, and it's finally great to be able to test all parts of the app.

Copy link
Contributor

@BrianLa0616 BrianLa0616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides geolocator not working for me, it looks good! The animation is really nice and hopefully this makes it easier to implement features!

@cgu2020 cgu2020 merged commit b81a19e into master Feb 7, 2024
10 checks passed
@cgu2020 cgu2020 deleted the journey-challenges-navbar branch February 7, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants