Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Global Leaderboard Page #139

Merged
merged 11 commits into from
Nov 30, 2023
Merged

Conversation

tuckerstanley
Copy link
Contributor

@tuckerstanley tuckerstanley commented Oct 23, 2023

Summary

This represents the completed leaderboard page. The data being displayed is mock data because at the moment there is errors fetching data from the database. The top 3 users are displayed in the podium, and if the user is on the podium their spot is shown in yellow, otherwise in red. If the user is in the scrollable list, they appear in a shaded yellow. The listview is scrollable, and consists of leaderboard cell widgets. Some images are attached.

Screenshot 2023-11-13 at 2 00 12 PM Screenshot 2023-11-13 at 1 46 15 PM

@dti-github-bot
Copy link
Member

dti-github-bot commented Oct 23, 2023

[diff-counting] Significant lines: 475.

Copy link
Contributor

@cgu2020 cgu2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back_button is probably broken.

Copy link
Contributor

@cgu2020 cgu2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops wrong PR

Copy link
Contributor

@cgu2020 cgu2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! There's a really small seem on the leaderboard podium for whatever reason. Might be an issue with the svg or gradient of the svg. Works on iOS with no issues.

@tuckerstanley tuckerstanley merged commit 81c8d82 into master Nov 30, 2023
10 checks passed
@tuckerstanley tuckerstanley deleted the tws76/new-global-leaderboard branch November 30, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants