Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lua compilation #177

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

theseion
Copy link
Contributor

  • update Lua to 5.3 (the highest supported version)
  • add missing Lua packages (httpd comes with Lua 5.2 installed, but if we want 5.3 we need to include that package in the final image)

Fixes #176

- update Lua to 5.3 (the highest supported version)
- add missing Lua packages (httpd comes with Lua 5.2 installed, but if
  we want 5.3 we need to include that package in the final image)

Fixes coreruleset#176
@theseion theseion requested a review from fzipi December 20, 2023 19:55
@fzipi fzipi merged commit 572ee19 into coreruleset:develop Dec 20, 2023
4 checks passed
@fzipi
Copy link
Member

fzipi commented Dec 20, 2023

Confirmed that build includes latest Lua:

 #9 8.610 checking for liblua config script... /usr/bin/pkg-config
#9 8.649 configure: using lua v5.3.6

@theseion theseion deleted the fix-lua-compilation branch December 21, 2023 05:53
@leveryd
Copy link

leveryd commented Jan 11, 2024

Good, i just test image "owasp/modsecurity-crs:3.3.5-nginx-alpine-202401080101". It shows good, have supported lua.

image

@theseion
Copy link
Contributor Author

Thanks @leveryd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Lua script support
3 participants