Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rawhide] upgrade.extended test fails on /var/cache/systemd mislabeled files #1819

Closed
c4rt0 opened this issue Oct 24, 2024 · 5 comments
Closed

[rawhide] upgrade.extended test fails on /var/cache/systemd mislabeled files #1819

c4rt0 opened this issue Oct 24, 2024 · 5 comments
Assignees
@dustymabe
Labels
jira for syncing to jira

Comments

@c4rt0
Copy link
Member

c4rt0 commented Oct 24, 2024 •
edited
Loading

kola-upgrade builds fail with Unexpected mislabeled file found: /var/cache/systemd, Unexpected mislabeled file found: /var/cache/systemd/home:

[2024-10-23T16:47:42.021Z] === RUN   ext.config.upgrade.extended
[2024-10-23T16:56:18.718Z] systemctl status kola-runext.service:
[2024-10-23T16:56:18.718Z] �� kola-runext.service
[2024-10-23T16:56:18.718Z]      Loaded: loaded (/etc/systemd/system/kola-runext.service; static)
[2024-10-23T16:56:18.718Z]     Drop-In: /usr/lib/systemd/system/service.d
[2024-10-23T16:56:18.718Z]              ������10-timeout-abort.conf
[2024-10-23T16:56:18.718Z]      Active: failed (Result: exit-code) since Wed 2024-10-23 16:56:03 UTC; 569ms ago
[2024-10-23T16:56:18.718Z]    Duration: 42.860s
[2024-10-23T16:56:18.718Z]  Invocation: 564b0845b3544e82a1d4f17133156b31
[2024-10-23T16:56:18.718Z]     Process: 1814 ExecStart=/usr/local/bin/kola-runext-test.sh (code=exited, status=1/FAILURE)
[2024-10-23T16:56:18.718Z]    Main PID: 1814 (code=exited, status=1/FAILURE)
[2024-10-23T16:56:18.718Z]    Mem peak: 207M
[2024-10-23T16:56:18.718Z]         CPU: 14.323s
[2024-10-23T16:56:18.718Z] 
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-a64-olinuxino-emmc.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-a64-pinetab-early-adopter.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h5-orangepi-zero-plus2.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h5-libretech-all-h3-it.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h616-x96-mate.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h6-tanix-tx6.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h5-bananapi-m2-plus-v1.2.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h616-bigtreetech-cb1-manta.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-a64-orangepi-win.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h5-libretech-all-h3-cc.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h5-libretech-all-h5-cc.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h700-anbernic-rg35xx-plus.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h5-nanopi-neo-plus2.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-a64-pinephone-1.0.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-a64-teres-i.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h6-orangepi-3.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-a64-pinetab.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-a64-pinephone-1.1.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h6-orangepi-lite2.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:03 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h5-orangepi-pc2.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-a100-allwinner-perf1.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h64-remix-mini-pc.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h618-orangepi-zero3.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h5-orangepi-zero-plus.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-a64-pinephone-1.2.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-a64-olinuxino.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-a64-sopine-baseboard.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h616-orangepi-zero2.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h5-orangepi-prime.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h616-bigtreetech-pi.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h6-beelink-gs1.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h5-nanopi-r1s-h5.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-h700-anbernic-rg35xx-h.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-a64-pine64.dtb
[2024-10-23T16:56:18.718Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/allwinner/sun50i-a64-nanopi-a64.dtb
[2024-10-23T16:56:18.719Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/nvidia
[2024-10-23T16:56:18.719Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/nvidia/tegra194-p3509-0000+p3668-0001.dtb
[2024-10-23T16:56:18.719Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/nvidia/tegra210-p2371-0000.dtb
[2024-10-23T16:56:18.719Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/nvidia/tegra132-norrin.dtb
[2024-10-23T16:56:18.719Z] Oct 23 16:56:04 qemu0 kola-runext-test.sh[1814]: /boot/ostree/fedora-coreos-7968767c12547db8083ebe1f9c93df060a08a988de61b31b65c4413f03cf76a8/dtb/nvidia/tegra234-p3768-0000+p3767-0005.dtb
[2024-10-23T16:56:18.719Z] --- FAIL: ext.config.upgrade.extended (507.90s)
[2024-10-23T16:56:18.719Z]         cluster.go:151: Error: Unit kola-runext.service exited with code 1
[2024-10-23T16:56:18.719Z]         cluster.go:151: 2024-10-23T16:56:03Z cli: Unit kola-runext.service exited with code 1
[2024-10-23T16:56:18.719Z]         harness.go:1265: kolet failed: : kolet run-test-unit failed: Process exited with status 1
[2024-10-23T16:56:18.719Z] FAIL, output in /home/jenkins/agent/workspace/kola-upgrade/tmp/kola-NmLr1/kola-uefi

From console.txt:

[   61.867810] kola-runext-test.sh[1814]: + read -r path
[   61.868409] kola-runext-test.sh[1814]: + [[ /var/cache/systemd =~ /etc/selinux/targeted/active/ ]]
[   61.869413] kola-runext-test.sh[1814]: + [[ /var/cache/systemd =~ /boot/ostree/.*/dtb ]]
[   61.870320] kola-runext-test.sh[1814]: + [[ noexception == \n\o\e\x\c\e\p\t\i\o\n ]]
[   61.871177] kola-runext-test.sh[1814]: + echo 'Unexpected mislabeled file found: /var/cache/systemd'
[   61.872178] kola-runext-test.sh[1814]: Unexpected mislabeled file found: /var/cache/systemd
[   61.873092] kola-runext-test.sh[1814]: + found=1
[   61.873616] kola-runext-test.sh[1814]: + read -r path
[   61.874214] kola-runext-test.sh[1814]: + [[ /var/cache/systemd/home =~ /etc/selinux/targeted/active/ ]]
[   61.875241] kola-runext-test.sh[1814]: + [[ /var/cache/systemd/home =~ /boot/ostree/.*/dtb ]]
[   61.876172] kola-runext-test.sh[1814]: + [[ noexception == \n\o\e\x\c\e\p\t\i\o\n ]]
[   61.877028] kola-runext-test.sh[1814]: + echo 'Unexpected mislabeled file found: /var/cache/systemd/home'
[   61.878058] kola-runext-test.sh[1814]: Unexpected mislabeled file found: /var/cache/systemd/home

console.txt
journal.txt
@dustymabe
Copy link
Member

In the logs I see:

Would relabel /var/cache/systemd from system_u:object_r:var_t:s0 to system_u:object_r:systemd_cache_t:s0                                   
Would relabel /var/cache/systemd/home from system_u:object_r:var_t:s0 to system_u:object_r:systemd_homed_cache_t:s0

Probably the policy has just changed for these files and we need to add exceptions to our test for them.

@dustymabe dustymabe changed the title [rawhide] ext.config.upgrade.extended fails [rawhide] upgrade.extended test fails on /var/cache/systemd mislabeled files Oct 24, 2024
@travier
Copy link
Member

travier commented Oct 24, 2024

Yes, the labels on the existing files (in /var) are not updated when the association changes in the policy.

@dustymabe
Copy link
Member

Yes, the labels on the existing files (in /var) are not updated when the association changes in the policy.

I wonder if that ever causes problems on upgrading systems? i.e. basically the policy has to allow for the older default labels forever?

@dustymabe
Copy link
Member

Upstream change that caused this:

dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Oct 24, 2024
@dustymabe
tests/kola: add SELinux systemd /var/cache exceptions in upgrade test
d659db6 
coreos/fedora-coreos-tracker#1819 (comment)
@dustymabe dustymabe mentioned this issue Oct 24, 2024
Merged
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue Oct 28, 2024
@dustymabe
tests/kola: add SELinux systemd /var/cache exceptions in upgrade test
6d4d368 
coreos/fedora-coreos-tracker#1819 (comment)
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Oct 28, 2024
@dustymabe
tests/kola: add SELinux systemd /var/cache exceptions in upgrade test
befd620 
coreos/fedora-coreos-tracker#1819 (comment)
(cherry picked from commit 6d4d368)
@dustymabe dustymabe mentioned this issue Oct 28, 2024
Merged
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue Oct 28, 2024
@dustymabe
tests/kola: add SELinux systemd /var/cache exceptions in upgrade test
0be8682 
coreos/fedora-coreos-tracker#1819 (comment)
(cherry picked from commit 6d4d368)
@dustymabe dustymabe self-assigned this Oct 28, 2024
@dustymabe dustymabe added the jira for syncing to jira label Oct 28, 2024
@dustymabe
Copy link
Member

This should be handled by coreos/fedora-coreos-config#3225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dustymabe dustymabe

Labels
jira for syncing to jira
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dustymabe @c4rt0 @travier