Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Management Panel UI #405

Closed
aehnh opened this issue Jul 29, 2024 · 6 comments · May be fixed by #406
Closed

User Management Panel UI #405

aehnh opened this issue Jul 29, 2024 · 6 comments · May be fixed by #406
Assignees

Comments

@aehnh
Copy link
Collaborator

aehnh commented Jul 29, 2024

No description provided.

@aehnh aehnh self-assigned this Jul 29, 2024
@aehnh aehnh linked a pull request Jul 29, 2024 that will close this issue
@aehnh
Copy link
Collaborator Author

aehnh commented Jul 29, 2024

as-is: only display components if the user has identifier
to-be: display components if project supports identifier. If user doesn't have the identifier, add an option to add it

@aehnh
Copy link
Collaborator Author

aehnh commented Jul 29, 2024

as-is: only display components if the user has identifier to-be: display components if project supports identifier. If user doesn't have the identifier, add an option to add it

Need to add a new public frontend api v2 endpoint that returns which identifier types (+ full name) are enabled?

Options:

  1. New endpoint getSupportedIdentifierTypes(fullNameRequired, identifierConfig, socialConfig). Is this too much information for a public API endpoint? Can be limited to array of identifierTypes and array of socialProviderTypes.
  2. Add the fields as optional fields to the existing GetSessionConfig in fapiv2

@aehnh
Copy link
Collaborator Author

aehnh commented Jul 30, 2024

At first I thought the updated @corbado/types code needs to be published to npm registry, but it seems the issue is bigger than that:

Simply using LoginIdentifierType from packages/react breaks the lerna build command. If I add @corbado/types to packages/react/webpack.prod.js and packages/web-js/tsconfig.bundler.json, lerna build is fixed but running react playground fails.

Since everything works correctly outside this branch, it seems that modifying interdependent packages (react, shared-ui, types) simultaneously seems to cause the problem. Is there a best-practice for this that i'm not aware of?

@aehnh
Copy link
Collaborator Author

aehnh commented Jul 30, 2024

At first I thought the updated @corbado/types code needs to be published to npm registry, but it seems the issue is bigger than that:

Simply using LoginIdentifierType from packages/react breaks the lerna build command. If I add @corbado/types to packages/react/webpack.prod.js and packages/web-js/tsconfig.bundler.json, lerna build is fixed but running react playground fails.

Since everything works correctly outside this branch, it seems that modifying interdependent packages (react, shared-ui, types) simultaneously seems to cause the problem. Is there a best-practice for this that i'm not aware of?

It works when I use LoginIdentifierType from shared-ui instead of from corbado/types... why??? :(

@incorbador
Copy link
Contributor

incorbador commented Aug 13, 2024

  • Improve the UI together with @Dopeamin => TODO: make a list of required changes

  • Check for usage of translations (compare with PasskeyList)

  • Include into previewui

  • Think about documentation in README.mds of the javascript repo and in docs.corbado.com (compare with PasskeyList)

  • Think about pentesting

@aehnh
Copy link
Collaborator Author

aehnh commented Aug 13, 2024

todos for changes to the UI

  1. fix and use css variables in user.css
  2. proper coloring for light/dark modes (i guess this point is enabled by point 1)
  3. import the email+phone verification UI from login flow
  4. modularize name, username, email, and phone cards into different components/files like in passkeylist?
  5. create dropdown menu for "verify" and "delete" options for each email/phone
  6. ensure smooth responsive design
  7. add confirmation dialogs for when deleting an identifier, or deleting the account, as shown in figma
  8. handle what happens after successful account deletion (not specified in figma. direct to a confirmation page? go straight to login page?)
  9. generally improve every component to match the figma design (regarding size, padding, border, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants