Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to parameters in cloudwatch-metrics integration policy #157

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add validation to parameters in cloudwatch-metrics integration policy #157

wants to merge 5 commits into from

Conversation

guyrenny
Copy link
Contributor

@guyrenny guyrenny commented Sep 15, 2024 •
edited
Loading

Description

  • Add validation to variables: ExternalIdSecret, CustomAccountId
  • Rename variables:
    ExternalId --> ExternalIdSecret
    CustomerAccountId --> CustomAccountId
  • Change ExternalId format to be of structure ExternalIdSecret@AWSAccount

CDS-1522

Fixes #

How Has This Been Tested?

Checklist:

  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's readme or docs change)

@guyrenny guyrenny requested a review from a team as a code owner September 15, 2024 09:31
@CLAassistant
Copy link

CLAassistant commented Sep 15, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

RafalSumislawski
RafalSumislawski requested changes Sep 16, 2024
View reviewed changes
Copy link
Member

@RafalSumislawski RafalSumislawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should use company_id

@coralogix coralogix deleted a comment from guyrenny Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtimush rtimush rtimush approved these changes

@RafalSumislawski RafalSumislawski Awaiting requested review from RafalSumislawski

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guyrenny @CLAassistant @rtimush @RafalSumislawski