Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the dispatch panel, add selection with SHIFT/MAJ key in unassigned tasks + ESC press shortcut to unselect all #4772

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Atala
Copy link
Member

@Atala Atala commented Nov 28, 2024

No description provided.

Copy link
Contributor

@vladimir-8 vladimir-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I guess you fixed #4068 too

return (
<div className="dashboard__aside-container">
<div className="dashboard__aside-container" onKeyDown={ (e) => e.keyCode === 27 && unselectAll() }>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=== 27 create a const instead for a magic number

@@ -93,6 +93,7 @@
"ADMIN_DASHBOARD_FILTERS_SHOW_ALL": "Show all",
"ADMIN_DASHBOARD_FILTERS_HIDE": "Hide",
"ADMIN_DASHBOARD_HIDE_SHOW_ON_MAP": "Hide/show on map",
"ADMIN_DASHBOARD_ONLY_UNASSIGNED_WITH_SHIFT": "Only unassigned tasks column handle shift selection",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can mention that a user can use command key on macos / Ctrl? on windows to select individual tasks. I tested it works for both unassigned and assigned tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the dispatch, enable SHIFT/MAJ selection in unassigned tasks column + ESC key to unselect all
2 participants