Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Webhook deployments from git commits don't respect [skip ci] #4357

Closed
sisou opened this issue Nov 21, 2024 · 1 comment
Closed

[Bug]: Webhook deployments from git commits don't respect [skip ci] #4357

sisou opened this issue Nov 21, 2024 · 1 comment

Comments

@sisou
Copy link

sisou commented Nov 21, 2024

Error Message and Logs

For CIs it has been established as a standard to be able to put [skip ci] somewhere in a commit message to tell the CI to not run with this commit.

I noticed earlier that deployments by webhook for, in my case, Github pushes still trigger deployments in Coolify.

I think they should be skipped when [skip ci] is found in the commit message.

It's also ok to introduce another keyword.

Steps to Reproduce

  1. Push a commit to a auto-deployed repo with [skip ci] in the commit message
  2. Observe that any configured Github Actions do not run for this commit
  3. Observe that Coolify still deploys the commit

Example Repository URL

No response

Coolify Version

v4.0.0-beta.370

Are you using Coolify Cloud?

No (self-hosted)

Operating System and Version (self-hosted)

Ubuntu 22.04.5 LTS

Additional Information

No response

@sisou sisou added 🐛 Bug Reported issues that need to be reproduced by the team. 🔍 Triage Issues that need assessment and prioritization. labels Nov 21, 2024
@peaklabs-dev
Copy link
Member

This is more of an improvement request as it has not yet been implemented, so I am moving this to a GitHub discussion.

@coollabsio coollabsio locked and limited conversation to collaborators Nov 21, 2024
@peaklabs-dev peaklabs-dev converted this issue into discussion #4358 Nov 21, 2024
@github-actions github-actions bot removed 🐛 Bug Reported issues that need to be reproduced by the team. 🔍 Triage Issues that need assessment and prioritization. labels Nov 21, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants