Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameter-set heatpumpVisibility and it's usage #32

Open
BlackEdder0815 opened this issue Oct 15, 2022 · 3 comments
Open

parameter-set heatpumpVisibility and it's usage #32

BlackEdder0815 opened this issue Oct 15, 2022 · 3 comments

Comments

@BlackEdder0815
Copy link

Hi @coolchip,

I just checked your code because I want to create a PR with some additional parameters (de-aerate) - I currently have the issue, that at least one of my pumps get stuck every summer and needs to run regularly.
To my question: I found this mysterious byte-block 3005, what’s called “visibility”. It’s used for reading some values, like the “heating_curve_end_point”, which is checking the value “207”. The only “documentation” about this values I found here https://github.com/Bouni/Luxtronik-2/blob/master/documentation.md
But looking at 207, the related identifier of this is “ID_Visi_Sprachen_DANSK“ what doesn’t make any sense.
Can you elaborate, for what this visibility is used and what “207” stays for?
Happy to provide you a PR with some additional stuff.

The de-aerate props I have already in, just wondering, If I have anything to do with the visibility.

@coolchip
Copy link
Owner

Hello. The block with the visibility codes are only for visibility. The pump marks ununsed parameters with visibility=false. If you want a list with all possible codes, look here:
https://github.com/Bouni/Luxtronik-2/blob/master/documentation.md#meaning-of-the-data

@BlackEdder0815
Copy link
Author

Thanks for the list.
According to this list, the “heating end-point” is only visible, when “Sprachen_DANSK” is set. This doesn’t make any sense to me… Or do I read/interpret this somehow wrong?

@coolchip
Copy link
Owner

coolchip commented Nov 3, 2022

You are right. That makes definitly no sense. I've no detailed information about those visibility parameters. If you are unsure, remove those if-clause with the visibility paramter. Instead of
(heatpumpVisibility[167] === 1) ? heatpumpParameters[688] : 'no'
use just:
heatpumpParameters[688]
There is nothing wrong with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants