Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normalizeStopTimes flag to RDBMS snapshots preserve stop_sequence vals #285

Merged
merged 2 commits into from
Apr 23, 2020

Conversation

landonreed
Copy link
Contributor

@landonreed landonreed commented Apr 23, 2020

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

re #283

@codecov-io
Copy link

codecov-io commented Apr 23, 2020

Codecov Report

Merging #285 into dev will decrease coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #285      +/-   ##
============================================
- Coverage     65.35%   65.35%   -0.01%     
- Complexity      880      881       +1     
============================================
  Files           135      135              
  Lines          6743     6745       +2     
  Branches        794      794              
============================================
+ Hits           4407     4408       +1     
  Misses         2037     2037              
- Partials        299      300       +1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/conveyal/gtfs/GTFS.java 55.26% <33.33%> (-0.30%) 12.00 <1.00> (ø)
.../com/conveyal/gtfs/loader/JdbcGtfsSnapshotter.java 82.44% <100.00%> (+0.09%) 27.00 <1.00> (ø)
src/main/java/com/conveyal/gtfs/loader/Table.java 85.18% <100.00%> (ø) 74.00 <0.00> (+1.00)
src/main/java/com/conveyal/gtfs/PatternFinder.java 85.22% <0.00%> (ø) 20.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 686ccae...0487783. Read the comment docs.

TestUtils.dropDB(testDBName);
throw e;
}
boolean snapshotIsOk = assertThatSnapshotIsSuccessful(namespace, dataSource, testDBName, persistenceExpectations, false);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this test and the one just below, I kinda want to write if (!assert...()) return false.

Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a missing JavaDoc and rename some variables inside GTFSTest.java. Thanks!

Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.

@landonreed landonreed merged commit 7e02187 into dev Apr 23, 2020
@landonreed landonreed deleted the normalize-stop-times-flag branch April 23, 2020 19:55
@landonreed
Copy link
Contributor Author

🎉 This PR is included in version 6.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants