-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add normalizeStopTimes flag to RDBMS snapshots preserve stop_sequence vals #285
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #285 +/- ##
============================================
- Coverage 65.35% 65.35% -0.01%
- Complexity 880 881 +1
============================================
Files 135 135
Lines 6743 6745 +2
Branches 794 794
============================================
+ Hits 4407 4408 +1
Misses 2037 2037
- Partials 299 300 +1
Continue to review full report at Codecov.
|
TestUtils.dropDB(testDBName); | ||
throw e; | ||
} | ||
boolean snapshotIsOk = assertThatSnapshotIsSuccessful(namespace, dataSource, testDBName, persistenceExpectations, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this test and the one just below, I kinda want to write if (!assert...()) return false
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a missing JavaDoc and rename some variables inside GTFSTest.java. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes.
🎉 This PR is included in version 6.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Checklist
dev
before they can be merged tomaster
)Description
re #283