Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent commit breaks the build #48

Open
okigan opened this issue Aug 9, 2024 · 3 comments · May be fixed by #49
Open

Recent commit breaks the build #48

okigan opened this issue Aug 9, 2024 · 3 comments · May be fixed by #49

Comments

@okigan
Copy link

okigan commented Aug 9, 2024

@sts07142 the 2138bbcdc3071e9e2413a125d107332723a3890a change breaks the build:

$ npm install && npm run build                         

up to date, audited 419 packages in 632ms

133 packages are looking for funding
  run `npm fund` for details

9 vulnerabilities (1 low, 5 moderate, 3 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> @context-labs/[email protected] build
> tsc

src/cli/commands/index/processRepository.ts:124:41 - error TS2345: Argument of type 'LLMModels' is not assignable to parameter of type 'TiktokenModel'.

124     const encoding = encoding_for_model(model.name);
                                            ~~~~~~~~~~

src/cli/commands/index/selectModel.ts:78:41 - error TS2345: Argument of type 'LLMModels' is not assignable to parameter of type 'TiktokenModel'.

78     const encoding = encoding_for_model(model);
                                           ~~~~~


Found 2 errors in 2 files.

Errors  Files
     1  src/cli/commands/index/processRepository.ts:124
     1  src/cli/commands/index/selectModel.ts:78
@sts07142 sts07142 linked a pull request Aug 10, 2024 that will close this issue
@sts07142
Copy link
Contributor

#49
We need to upgrade version @dqbd/tiktoken.
@dqbd/tiktoken 1.0.2 -> 1.0.15

@salimmj
Copy link

salimmj commented Aug 11, 2024

#49 We need to upgrade version @dqbd/tiktoken. @dqbd/tiktoken 1.0.2 -> 1.0.15

I don't think this fixes it

@sts07142
Copy link
Contributor

#49
fix: Add function to convert model's name when using gpt-4o-mini.

@dqbd/tiktoken encoding_for_model( )
^ It doesn't have gpt-4o-mini's encoding model, but same encoding model as gpt-4o (o200k_base)

Fix errors in Errors Files
1 src/cli/commands/index/processRepository.ts:124
1 src/cli/commands/index/selectModel.ts:78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants