Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to 'create' to choose a custom hostname #563

Closed
mvalahtv opened this issue Sep 21, 2020 · 6 comments
Closed

Add an option to 'create' to choose a custom hostname #563

mvalahtv opened this issue Sep 21, 2020 · 6 comments
Labels
1. Feature request A request for a new feature

Comments

@mvalahtv
Copy link

mvalahtv commented Sep 21, 2020

Is your feature request related to a problem? Please describe.
I would like to have multiple toolboxes so it would be nice if we can define hostname instead of toolbox.

Describe the solution you'd like
It can be done via

toolbox create -h mytoolbox
@meeas
Copy link

meeas commented Jun 3, 2022

Related to this, can we also add a method to add a hostname after a toolbox has been created? I assume we can use podman to add a hostname to a running toolbox, but I suspect that the hostname will not persist trough reboots.

@debarshiray
Copy link
Member

debarshiray commented Oct 14, 2022

#969 has some good ideas on how to chose a better default for the container's host name.

One problem with setting the host name through podman create --host ..., like we do today, is that any attempt to change the hostname later doesn't persist across a container restart. This seems somewhat important, if we want to change the container's host name to uniquely identify them.

Of course, users can hack this up using their shell start-up scripts, but it will be good to come up with a less barbaric solution. :)

One option could be to leverage the toolbox init-container entry point to repeatedly set the intended host name on container start-up.

@debarshiray
Copy link
Member

Let's first try to improve the default hostname that gets chosen for a Toolbx container before trying to come up with ways to customize it.

I don't want to offer users a way to choose a custom name when creating a Toolbx container, until we have figured out a way in which that name can be modified afterwards. If a person wants custom names for their containers, it's not a stretch to imagine that they might want to change the name afterwards, and as I mentioned above, it's tricky to change the name later.

I do understand why users want to customize the names, though, and I do accept it as a reasonable thing to do. It's just that we haven't figured out a way to do that properly.

Improving the default name is still going to be an improvement, and we have a clear way ahead, so let's focus on that first. Baby steps. :)

@debarshiray
Copy link
Member

I am going to close this issue in favour of #969 so that the list of open issues doesn't balloon out of control, and continues to roughly reflect the items that are on the current to-do list. However, it will still be around for future reference.

@debarshiray
Copy link
Member

debarshiray commented Nov 17, 2022

Duplicate of #969

@debarshiray
Copy link
Member

I don't want to offer users a way to choose a custom name when creating a
Toolbx container, until we have figured out a way in which that name can be
modified afterwards. If a person wants custom names for their containers,
it's not a stretch to imagine that they might want to change the name
afterwards, and as I mentioned above, it's tricky to change the name later.

The second comment on this issue is exactly what I was talking about. :)

@debarshiray debarshiray changed the title Define hostname when creating toolbox Add an option to 'create' to choose a custom hostname Nov 17, 2022
@debarshiray debarshiray marked this as a duplicate of #969 Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. Feature request A request for a new feature
Projects
None yet
Development

No branches or pull requests

3 participants