Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support override via platform specifier #2118

Open
rittneje opened this issue Sep 24, 2023 · 8 comments · May be fixed by #2175
Open

support override via platform specifier #2118

rittneje opened this issue Sep 24, 2023 · 8 comments · May be fixed by #2175
Labels
kind/feature A request for, or a PR adding, new functionality

Comments

@rittneje
Copy link
Contributor

Currently skopeo accepts three distinct flags for overriding the default (host) platform selection: --override-os, --override-arch, and --override-variant.

When working with other tools such as buildkit, the platform is instead specified as a single slash-delimited string, such as linux/arm64 or linux/arm/v7. This format is explained in further detail here.

It would be nice if skopeo accepted a new flag such as --override-platform that accepted such a platform specifier. And probably the three existing override flags should be deprecated.
@mtrmac mtrmac added the kind/feature A request for, or a PR adding, new functionality label Sep 25, 2023
@mtrmac
Copy link
Contributor

mtrmac commented Sep 25, 2023

Thanks, yes, that looks potentially useful.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rittneje
Copy link
Contributor Author

not stale

@github-actions GitHub Actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rittneje
Copy link
Contributor Author

Not stale

@rhatdan
Copy link
Member

rhatdan commented Nov 26, 2023

Interested in opening a PR?

rittneje added a commit to rittneje/skopeo that referenced this issue Dec 6, 2023
@rittneje
Add support for --override-platform flag. Closes containers#2118.
5534e8d 
Signed-off-by: Jesse Rittner <[email protected]>
rittneje added a commit to rittneje/skopeo that referenced this issue Dec 6, 2023
@rittneje
Add support for --override-platform flag. Closes containers#2118.
ad8f7ca 
Signed-off-by: Jesse Rittner <[email protected]>
@rittneje rittneje linked a pull request Dec 6, 2023 that will close this issue
Draft
@rittneje
Copy link
Contributor Author

rittneje commented Dec 6, 2023

@rhatdan I opened a draft PR.

@rhatdan
Copy link
Member

rhatdan commented Dec 6, 2023

Great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature A request for, or a PR adding, new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for --override-platform flag rittneje/skopeo
3 participants
@rhatdan @mtrmac @rittneje