Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Windows installer to use WiX 4 Thmutil RadioButton to allow WSL/Hyper-V selection #22492

Closed
l0rd opened this issue Apr 24, 2024 · 1 comment · Fixed by #23936
Closed

Update Windows installer to use WiX 4 Thmutil RadioButton to allow WSL/Hyper-V selection #22492

l0rd opened this issue Apr 24, 2024 · 1 comment · Fixed by #23936
Labels
jira kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue

Comments

@l0rd
Copy link
Member

l0rd commented Apr 24, 2024 •
edited
Loading

Feature request description

TL;DR podman windows setup.exe should use radio buttons to present the machine provider alternatives (WSL and HyperV). But that requires WiX v4.

The selection of the machine provider (WSL or Hyper-V) requires radio buttons in the installer GUI. That can be implemented using WiX v3 RadioButton for the MSI package (podman.msi) but requires WiX v4 for the podman-setup.exe bundle.

In fact the windows installer podman-setup.exe is a bundle that includes:

  • the MSI package podman.msi
  • the executable podman-wslkerninst.exe

Most importantly for this issue, the the podman-setup.exe GUI is implemented with WiX Standard Bootstrapper Application customized using a ThemeFile and is different from the podman.msi GUI.

WiX v3 Boostrapper Application Theme doesn't have radio buttons but v4 does.

Suggest potential solution

Use https://wixtoolset.org/docs/schema/thmutil/radiobutton/.

Have you considered any alternatives?

We could use a checkbox

[ ] use Hyper-V rather then WSL

but that's not ideal.

Additional context

Add any other context or screenshots about the feature request here.
@l0rd l0rd added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 24, 2024
@l0rd l0rd changed the title Update Windows installer to use WiX 4 Thmutil RadioButton to allow WSL/Hyper- selection Update Windows installer to use WiX 4 Thmutil RadioButton to allow WSL/Hyper-V selection Apr 24, 2024
@l0rd l0rd added the jira label Apr 24, 2024
@l0rd l0rd mentioned this issue Apr 25, 2024
Merged
lsm5 pushed a commit to lsm5/podman that referenced this issue May 10, 2024
@l0rd @lsm5
Add Hyper-V option in windows installer
970d714 
podman.msi GUI has a radio-button to select WSL or Hyper-V

The checkbox in podman.msi GUI allow the user to specify if
the machine provider installation (WSL or Hyper-V) should
be part of podman installation or not.

podman-setup.exe supports 2 new variables: MachineProvider
(valid values are `wsl` and `hyperv`) and HyperVCheckbox
(valid values are `0` and `1`)

Installation creates the configuration file
`99-podman-machine-provider.conf` under folder
`%APPDATA\containers\containers.conf.d` with the selected
machine provider

Cirrus CI `win_installer_task` tests the installation with
both `hyperv` and `wsl` and verifies the configuration.
Uninstallation is tested too.

Note that podman-setup.exe GUI doesn't allow to choose the
provider yet. See containers#22492

Signed-off-by: Mario Loriedo <[email protected]>
@github-actions GitHub Actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

l0rd added a commit to l0rd/podman that referenced this issue May 29, 2024
@l0rd
Add Hyper-V option in windows installer
fb4ddf8 
podman.msi GUI has a radio-button to select WSL or Hyper-V

The checkbox in podman.msi GUI allow the user to specify if
the machine provider installation (WSL or Hyper-V) should
be part of podman installation or not.

podman-setup.exe supports 2 new variables: MachineProvider
(valid values are `wsl` and `hyperv`) and HyperVCheckbox
(valid values are `0` and `1`)

Installation creates the configuration file
`99-podman-machine-provider.conf` under folder
`%APPDATA\containers\containers.conf.d` with the selected
machine provider

Cirrus CI `win_installer_task` tests the installation with
both `hyperv` and `wsl` and verifies the configuration.
Uninstallation is tested too.

Note that podman-setup.exe GUI doesn't allow to choose the
provider yet. See containers#22492

Signed-off-by: Mario Loriedo <[email protected]>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/podman that referenced this issue May 29, 2024
@l0rd
Add Hyper-V option in windows installer
7df3715 
podman.msi GUI has a radio-button to select WSL or Hyper-V

The checkbox in podman.msi GUI allow the user to specify if
the machine provider installation (WSL or Hyper-V) should
be part of podman installation or not.

podman-setup.exe supports 2 new variables: MachineProvider
(valid values are `wsl` and `hyperv`) and HyperVCheckbox
(valid values are `0` and `1`)

Installation creates the configuration file
`99-podman-machine-provider.conf` under folder
`%APPDATA\containers\containers.conf.d` with the selected
machine provider

Cirrus CI `win_installer_task` tests the installation with
both `hyperv` and `wsl` and verifies the configuration.
Uninstallation is tested too.

Note that podman-setup.exe GUI doesn't allow to choose the
provider yet. See containers#22492

Signed-off-by: Mario Loriedo <[email protected]>
@jingyuwa jingyuwa mentioned this issue Aug 13, 2024
Closed
@l0rd l0rd mentioned this issue Sep 11, 2024
Merged
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Dec 13, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
jira kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. stale-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add radio buttons to select WSL or Hyper-V in windows setup.exe l0rd/podman
1 participant
@l0rd