-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the "docker-archive" format of "podman save" OCI-compatible following Docker 25 release #21347
Comments
Seems like something that should be done for 5.0. |
Fixes: containers#21347 This is a breaking change. Signed-off-by: Daniel J Walsh <[email protected]>
For reference, ~copying my comment from #21355: We actually don’t want to just switch the format. Docker 25 is doing something more interesting: they are creating a single archive which is consumable both as an OCI archive and as a traditional Creating such a hybrid archive in |
Hi, In practice, since this issue is rather important to us (Amadeus), I guess I will end up trying to implement it. Let's say the current docker 25 format is implemented (this is purely internal podman matter), from a user point of view how do you see the command line interface ?
|
(That’s not quite how that works, the code to create the archives exists in I think the first thing is to confirm for sure whether the combined OCI+new-Docker format is, or isn’t, compatible with old-Docker; my text above is just what I remember from a fairly brief skim of the new Docker code; and the new Docker code does seem to still create the legacy data, although I can’t see how it is actually consumable. It might be the case that there isn’t any incompatibility, and that we can always generate an archive that is valid in all three formats simultaneously. In that case I think we should just do that, and not burden the user with questions. The design trade-offs only come into play if the three-format archive is impossible. |
A friendly reminder that this issue had no activity for 30 days. |
Feature request description
Following docker 25 release, "docker image save" now seems to use OCI archive format by default (see release notes https://docs.docker.com/engine/release-notes/25.0/ and moby/moby#44598).
For other reasons (see #20611 containers/image#2151 and containers/image#2182) we might prefer OCI format by default for "podman save" rather than docker format.
So both to align with the latest docker behavior and to favor OCI over docker format, should we change the default output format of "podman save" from "docker-archive" to "oci-archive" ?
Suggest potential solution
Change the default output of "podman save" to "oci-archive".
Have you considered any alternatives?
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: