From 3fef531d96b100bfc96cd177753ebe904359c9fa Mon Sep 17 00:00:00 2001 From: Christophe Fergeau Date: Fri, 12 Jan 2024 10:57:38 -0500 Subject: [PATCH] applehv: return socket path from setupAPIForwarding When starting podman machine with applehv, this warning is printed: WARN[0025] API socket failed ping test This is due to a bug in applehv.setupAPIForwarding which is not returning the path to the socket, which causes `WaitAndPingAPI` to be called with `""` as the socket path, triggering the warning. This commit changes setupAPIForwarding to be similar to the implementation in the other machine implementations. I don't know how to add a test for this, but this can be handled in podman-machine end to end tests by making sure that there are no warnings when running `podman machine start` with applehv. [NO NEW TESTS NEEDED] Signed-off-by: Christophe Fergeau --- pkg/machine/applehv/machine.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/machine/applehv/machine.go b/pkg/machine/applehv/machine.go index afd86e0a32..ca96d959b9 100644 --- a/pkg/machine/applehv/machine.go +++ b/pkg/machine/applehv/machine.go @@ -1031,7 +1031,8 @@ func (m *MacMachine) setupAPIForwarding(cmd gvproxy.GvproxyCommand) (gvproxy.Gvp } } - return cmd, "", machine.MachineLocal + return cmd, socket.GetPath(), machine.MachineLocal + } func (m *MacMachine) dockerSock() (string, error) {