-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency containers/automation_images to v20231004 #335
Conversation
@umohnani8 PTAL, there's likely going to be a gating-test failure about a circular-dependency. I don't know this code, but my past python experience tells me these can be very tricky to fix w/o code-base knowledge. Can you help or help track down someone who can fix this? |
@cevich @umohnani8 This is going to take a deep drive into why pylint is throwing an error on |
514c0c5
to
5778393
Compare
I don't think I have any idea how to do that, but I agree it's strange. Could it be caused by changed package/module names in an updated (third-party) dependency maybe? |
@jwhonce is there a way to make the output more verbose, to provide more clues? |
So the cyclic import issue seems to be a bug with pylint based on pylint-dev/pylint#3285 and pylint-dev/pylint#3525. The issues say it has been fixed but our CI is still running into it even though I am not able to reproduce it locally with I checked the pylint versions and locally I am on 2.14.2 while I believe the CI is on 3.0.2 - so not sure why it is running into that issue. In #338 I have added a disable to that block to see if that works but I am not sure if it is the best way to go. @jwhonce wdyt? |
Nevermind, the disable doesn't help with the cyclic import issue :( |
Thanks for looking into this @umohnani8. I think we just need new CI VM images then, and a bit of luck they contain the fixed version. |
Ref: #335 (comment) Thanks to @umohnani8 for tracking this down. Signed-off-by: Chris Evich <[email protected]>
Let's try these images built yesterday by Ed (thanks!)... |
...Ugh, no updated package yet, still get same error:
But at least now we know what to do/look for. There's a podman issue (IIRC) needing new CI VM images, and these ones I just tried are also no good there. Point is, there should be new images flowing through in the near-term. |
63625c7
to
fe64e4f
Compare
fe64e4f
to
b487c86
Compare
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
b487c86
to
c009609
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, renovate[bot], rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR contains the following updates:
20230816t191118z-f38f37d13
->20231004t194547z-f39f38d13
Release Notes
containers/automation_images (containers/automation_images)
v20231004t194547z-f39f38d13
Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.