Open Model Folder

[feloy]

Fixes partially #50

[benoitf]

I would use uris everywhere

build the URI using

Uri.file(object.file.path)

and then not have in studioClient

  async openURL(url: string): Promise<boolean> {
    return await podmanDesktopApi.env.openExternal(podmanDesktopApi.Uri.parse(url));
  }

but just accept URI (to avoid double parse/unexpected behavior)

[benoitf]

I did not pay enough attention to backend/frontend usage so you may disregard my comment as basically frontend has no access to Podman Desktop API and the URI class.

so either you revert the commit or you have openFile(filePath: string) method on studio-client that will do openExternal(URI.file(filePath))

sorry for the noise

[lstocchi]

When opening the model folder i see this dialog but the title and text are wrong. I'm not opening any external website

[jeffmaury]

LGTM

[axel7083]

I had #122 open, I will put it as draft waiting for this one to be merged and reuse your code @feloy

[feloy]

When opening the model folder i see this dialog but the title and text are wrong. I'm not opening any external website

I created an issue on Podman Desktop: podman-desktop/podman-desktop#5732

[lstocchi]

I would fix the issue on desktop before releasing tbh but maybe @jeffmaury wants to have it for the release.

BTW looking at it again ... do we really need to show that dialog confirmation? We are just opening a local folder, nothing too serious. Can we just open the folder without asking to confirm?

[jeffmaury]

I would fix the issue on desktop before releasing tbh but maybe @jeffmaury wants to have it for the release.

BTW looking at it again ... do we really need to show that dialog confirmation? We are just opening a local folder, nothing too serious. Can we just open the folder without asking to confirm?

That maybe the cause of security issue, @benoitf WDYT ?

[benoitf]

I created the commit and the branch but forgot to open the PR

here it is podman-desktop/podman-desktop#5743