Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model displayed after cancelling download #517

Closed
vrothberg opened this issue Mar 13, 2024 · 8 comments · Fixed by #549
Closed

model displayed after cancelling download #517

vrothberg opened this issue Mar 13, 2024 · 8 comments · Fixed by #549
Assignees
Milestone

Comments

@vrothberg
Copy link
Member

When closing Podman Desktop while downloading a mode, the model is being displayed suggesting it can be used.

I suspect that the model is being downloaded to the final destination directly; writing it to a temp directory + rename may be safer.

image

@benoitf
Copy link
Collaborator

benoitf commented Mar 13, 2024

hello @vrothberg are you using the current main branch ?

b/c last week there was #389 and #458

@vrothberg
Copy link
Member Author

I was using the nightly build? Are those less nightly than the name suggests?

@benoitf
Copy link
Collaborator

benoitf commented Mar 13, 2024

nightly is published at each commit so should be good.
just wanted to double check

About your issue and the wording, closing means that you closed the Podman Desktop window or you exited Podman Desktop ? (if the window is only closed it is staying in the background)

@vrothberg
Copy link
Member Author

I ran on Linux which AFAIK closes Podman Desktop entirely.

@benoitf
Copy link
Collaborator

benoitf commented Mar 13, 2024

I'm able to reproduce

so you see in the 'Downloaded' section but not in the 'Available' section (as file is not completed)

but yes probably it's confusing (you don't know that file is still incomplete / can't resume the download, etc)

@lstocchi
Copy link
Contributor

@vrothberg how do you expect it to work? Should the incomplete download be removed or it should have a resume download?

@vrothberg
Copy link
Member Author

@vrothberg how do you expect it to work? Should the incomplete download be removed or it should have a resume download?

Both are fine by me. I think that removing it for now would be faster. Resuming would be nice but sounds like much more work.

@axel7083
Copy link
Contributor

https://github.com/projectatomic/ai-studio/blob/3aa45002b477cb79bbe200637a2242ccffb922b0/packages/backend/src/utils/downloader.ts#L88-L95

We already are using a *.tmp file name for the download and renaming it on download finish, @vrothberg can you ls the folder of the model to see the file in it ?

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✔️ Done in Podman Desktop Planning Mar 14, 2024
mhdawson pushed a commit to mhdawson/podman-desktop-extension-ai-lab that referenced this issue Nov 22, 2024
…e-images-to-312

bump python 3.11 to 3.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants