Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes: fix vagrant dotenv loading and default qemu directory. #389

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Oct 25, 2024

Fix e2e test vagrant setup to

  • explicitly require 'dotenv' before dotenv-loading an environment file
  • make the vagrant qemu directory configurable using the qemu_dir shell variable
  • use a default qemu directory which works on recent Fedora and OpenSUSE distros

Recent versions of vagrant fail to bootstrap with out generated
configuration unless we explicitly require 'dotenv' in Vagrantfile.

Signed-off-by: Krisztian Litkey <[email protected]>
Update Vagrant qemu_dir to a default which works with recent
versions of vagrant on both Fedora and OpenSUSE. Make qemu_dir
configurable via the same shell variable.

Signed-off-by: Krisztian Litkey <[email protected]>
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fmuyassarov fmuyassarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fmuyassarov fmuyassarov merged commit 4daf645 into containers:main Oct 28, 2024
3 checks passed
@klihub klihub deleted the fixes/e2e/vagrant branch November 7, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants