From c46451f353b892d68692573b5b6e0304b2e1b29f Mon Sep 17 00:00:00 2001
From: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
Date: Mon, 16 Oct 2023 14:10:26 +0300
Subject: [PATCH] deployment: drop DaemonSet unsupported restart policy

The DaemonSet controller currently only supports the 'Always' restart
policy, which is set by default. This commit addresses the issue of
incorrectly set 'OnFailure' restart policy in DaemonSet objects of
plugins, ensuring that only the 'Always' restart policy is used as
intended.

Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
---
 deployment/helm/balloons/templates/daemonset.yaml       | 1 -
 deployment/helm/memory-qos/templates/daemonset.yaml     | 1 -
 deployment/helm/memtierd/templates/daemonset.yaml       | 1 -
 deployment/helm/topology-aware/templates/daemonset.yaml | 1 -
 4 files changed, 4 deletions(-)

diff --git a/deployment/helm/balloons/templates/daemonset.yaml b/deployment/helm/balloons/templates/daemonset.yaml
index f4f067fb2..9ab27d088 100644
--- a/deployment/helm/balloons/templates/daemonset.yaml
+++ b/deployment/helm/balloons/templates/daemonset.yaml
@@ -14,7 +14,6 @@ spec:
       labels:
       {{- include "balloons-plugin.labels" . | nindent 8 }}
     spec:
-      restartPolicy: OnFailure
       serviceAccount: nri-resource-policy-balloons
       nodeSelector:
         kubernetes.io/os: "linux"
diff --git a/deployment/helm/memory-qos/templates/daemonset.yaml b/deployment/helm/memory-qos/templates/daemonset.yaml
index 88261bb56..ea870fc5c 100644
--- a/deployment/helm/memory-qos/templates/daemonset.yaml
+++ b/deployment/helm/memory-qos/templates/daemonset.yaml
@@ -14,7 +14,6 @@ spec:
       labels:
       {{- include "memory-qos.labels" . | nindent 8 }}
     spec:
-      restartPolicy: OnFailure
       nodeSelector:
         kubernetes.io/os: "linux"
       {{- if .Values.nri.patchRuntimeConfig }}
diff --git a/deployment/helm/memtierd/templates/daemonset.yaml b/deployment/helm/memtierd/templates/daemonset.yaml
index 8af4bc97a..af4c66b27 100644
--- a/deployment/helm/memtierd/templates/daemonset.yaml
+++ b/deployment/helm/memtierd/templates/daemonset.yaml
@@ -14,7 +14,6 @@ spec:
       labels:
       {{- include "memtierd.labels" . | nindent 8 }}
     spec:
-      restartPolicy: OnFailure
       nodeSelector:
         kubernetes.io/os: "linux"
       hostPID: true
diff --git a/deployment/helm/topology-aware/templates/daemonset.yaml b/deployment/helm/topology-aware/templates/daemonset.yaml
index 02e2bc9d0..01beaf2d4 100644
--- a/deployment/helm/topology-aware/templates/daemonset.yaml
+++ b/deployment/helm/topology-aware/templates/daemonset.yaml
@@ -14,7 +14,6 @@ spec:
       labels:
       {{- include "topology-aware-plugin.labels" . | nindent 8 }}
     spec:
-      restartPolicy: OnFailure
       serviceAccount: nri-resource-policy-topology-aware
       nodeSelector:
         kubernetes.io/os: "linux"