Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vlan for bridge #108

Closed
baude opened this issue Nov 30, 2021 · 7 comments · May be fixed by #146
Closed

vlan for bridge #108

baude opened this issue Nov 30, 2021 · 7 comments · May be fixed by #146
Assignees
@flouthoc
Labels
enhancement New feature or request

Comments

@baude
Copy link
Member

baude commented Nov 30, 2021

i cannot remember this one
@baude baude added the enhancement New feature or request label Nov 30, 2021
@flouthoc
Copy link
Collaborator

flouthoc commented Dec 6, 2021

Thanks picking this up.

@flouthoc flouthoc self-assigned this Dec 6, 2021
@flouthoc
Copy link
Collaborator

flouthoc commented Dec 8, 2021

@Luap99 @baude I have a question do we also need to create vlan interface or just want to tag the bridge with something equivalent to bridge vlan add dev DEV vid VID [ pvid ] [ untagged ] [ self ] [ master ]

@Luap99
Copy link
Member

Luap99 commented Dec 8, 2021

@flouthoc I have not looked at the cni code but we should match what they are doing IMO

@flouthoc
Copy link
Collaborator

flouthoc commented Dec 8, 2021

They are also creating vlan interface but our config does not have a option to specify should i add it.

@Luap99
Copy link
Member

Luap99 commented Dec 8, 2021

Why do you need a new field? The vlan number + interface name should name should be enough. https://www.cni.dev/plugins/current/main/bridge/

@flouthoc
Copy link
Collaborator

Upstream is missing support for setting bridge flags and bridge vlan info. I am plumbing upstream to support this.

@flouthoc
Copy link
Collaborator

There are few PR's waiting here to be merge. I don't know what else is missing but I'll figure it out https://github.com/little-dude/netlink/pulls

@flouthoc flouthoc mentioned this issue Jan 4, 2022
Open
@baude baude closed this as completed Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flouthoc flouthoc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

core: add support for vlan tag and vlan_filtering for bridge driver flouthoc/netavark
3 participants
@baude @flouthoc @Luap99