Moving From YAJL to Jansson #141
Conversation
Added a temporary function to yajl_val to json_t converted YAJL_GET_STRING to json_string_value converted YAJL_IS_NUMBER to json_is_number added functions from double to various int types. YAJL_GET_NUMBER returns string. While json_number_value returns double. Signed-off-by: Sourav Moitra <[email protected]>
xw19
force-pushed
the
switch-to-jansson-SM
branch
from
db89f16 to
78ccdaa
Compare
|
@giuseppe PTAL |
|
@saschagrunert are you ok to have this change in the |
|
tests are failing |
|
@xw19 can you please fixup the tests? :) |
|
@giuseppe @saschagrunert can we retrigger these test builds? |
|
I think the issue is caused by arm32v7 latest ubuntu images release last week https://hub.docker.com/r/arm32v7/ubuntu/tags There is update on the uraimo/run-on-arch-action tag v2.8.1 uraimo/run-on-arch-action@96c27aa Which coincides with the exact line failure https://github.com/containers/libocispec/actions/runs/11534806854/job/32210560862 |
xw19
force-pushed
the
switch-to-jansson-SM
branch
from
d132a05 to
e2d047f
Compare
|
it seems there is a missing file: |
|
I found the cause of the failure was probably because we were not running configure on the jansson hence the jansson_config.h is not being generated. https://jansson.readthedocs.io/en/latest/gettingstarted.html (edited: configure is being triggered) |
|
WIP: I will first run in my fork and fix then will revert back |
xw19
force-pushed
the
switch-to-jansson-SM
branch
2 times, most recently
from
696d678 to
9397552
Compare
Signed-off-by: Sourav Moitra <[email protected]>
xw19
force-pushed
the
switch-to-jansson-SM
branch
from
9397552 to
8588c67
Compare
|
@saschagrunert @giuseppe Please re-review I think I have fixed the CI issues https://github.com/xw19/libocispec/actions/runs/11688628819/job/32549520172?pr=1 |
|
Refers to #138 |
Moving YAJL to Jansson
Added a temporary function to yajl_val to json_t
converted YAJL_GET_STRING to json_string_value
converted YAJL_IS_NUMBER to json_is_number
added functions from double to various int types.
YAJL_GET_NUMBER returns string. While json_number_value returns double.