From 1ca9d8bfb3d8a08b2843ca1ff1a2d54e96642330 Mon Sep 17 00:00:00 2001 From: Christophe Fergeau Date: Thu, 1 Feb 2024 17:19:42 +0100 Subject: [PATCH 1/2] gh: Fix 'if:' statement to avoid multiple uploads `actions/upload-artifact` will fail if we try to upload multiple times the same artifact, which can happen in our setup with the matrix of go versions: ``` Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run ``` I tried to fix this before, but I got the `if:` condition wrong in the workflow YAML file: `if: matrix.go-version == '1.21.x'` should work better than `if: ${{ matrix.go-version }} == '1.21.x'` Signed-off-by: Christophe Fergeau --- .github/workflows/go.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 6015ad14d..c985ed734 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -32,7 +32,7 @@ jobs: mv bin/gvproxy.exe bin/gvproxy-windowsgui.exe - uses: actions/upload-artifact@v4 - if: ${{ matrix.go-version }} == '1.21.x' + if: matrix.go-version == '1.21.x' with: name: gvisor-tap-vsock-binaries path: bin/* From c988a2214f5928cf7428d36ae934cb934d90af57 Mon Sep 17 00:00:00 2001 From: Christophe Fergeau Date: Mon, 5 Feb 2024 16:28:19 +0100 Subject: [PATCH 2/2] OWNERS: Add jakecorrenti to reviewers Signed-off-by: Christophe Fergeau --- OWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/OWNERS b/OWNERS index d021e66a4..558fe5a82 100644 --- a/OWNERS +++ b/OWNERS @@ -5,4 +5,5 @@ approvers: reviewers: - baude - cfergeau + - jakecorrenti - praveenkumar