From 464252c53d9513af2d1332d5056e20570ba236be Mon Sep 17 00:00:00 2001 From: Alberto Faria Date: Fri, 15 Mar 2024 13:02:02 +0000 Subject: [PATCH] Don't use `--security-opt label=disable` with Docker crun-vm now works with Docker without this option on Fedora 39. Signed-off-by: Alberto Faria --- docs/2-podman-docker.md | 9 +++------ tests/run.rs | 11 +++-------- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/docs/2-podman-docker.md b/docs/2-podman-docker.md index 4e724a8..79bf774 100644 --- a/docs/2-podman-docker.md +++ b/docs/2-podman-docker.md @@ -1,11 +1,8 @@ # 2. Using crun-vm as a Podman or Docker runtime -Here we overview some of the major features provided by crun-vm. - -To run the examples below using Docker instead of Podman, you must additionally -pass `--security-opt label=disable` to docker-run. Other than that, and unless -otherwise stated, you can simply replace `podman` with `docker` in the commands -below. +Here we overview some of the major features provided by crun-vm. The commands +below use `podman`, but unless otherwise stated you can simply replace it with +`docker`. ## Booting VMs diff --git a/tests/run.rs b/tests/run.rs index 480a92e..11774fb 100644 --- a/tests/run.rs +++ b/tests/run.rs @@ -173,14 +173,9 @@ impl Engine { if subcommand == "run" { match self { - Engine::Podman => { - cmd.arg(format!("--runtime={}", BINARY_PATH)); - } - Engine::Docker => { - cmd.arg("--security-opt=label=disable"); - cmd.arg("--runtime=crun-vm"); - } - } + Engine::Podman => cmd.arg(format!("--runtime={}", BINARY_PATH)), + Engine::Docker => cmd.arg("--runtime=crun-vm"), + }; } cmd.env("RUST_BACKTRACE", "1");