Add dedicated error if no PID namespace should be unshared #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
saschagrunert
force-pushed
the
pid-namespace-error
branch
4 times, most recently
from
7ba968a to
7923015
Compare
|
@haircommander @rphillips PTAL |
We do not have to create the pause process on `CreateNamespaces` if no PID namespace should be unshared. In this case we now return a dedicated error and let the users decide what to do with it. Fixes containers#1066 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
pid-namespace-error
branch
from
7923015 to
a9038ae
Compare
|
I feel unsure about this approach... I still like the idea of having conmon-rs create all the namespaces for a pod eventually and deprecating pinns |
|
Yeah I see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We do not have to create the pause process on
CreateNamespacesif no PID namespace should be unshared. In this case we now return a dedicated error and let the users decide what to do with it.Which issue(s) this PR fixes:
Fixes #1066
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?