Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using systemd for pause PID #1041

Open
saschagrunert opened this issue Jan 27, 2023 · 2 comments
Open

Consider using systemd for pause PID #1041

saschagrunert opened this issue Jan 27, 2023 · 2 comments

Comments

@saschagrunert
Copy link
Member

We added support for handling namespaces in #908, where @cgwalters mentioned that we could consider using systemd for the PID handling: #908 (comment)

We can experiment with the implementation to see how much the resource overhead would be when using systemd.

@haircommander
Copy link
Collaborator

I am unsure we need systemd here. ultimately, conmon-rs will still be watching the lifecycle of the pause process. we don't want it to automatically restart, and conmon-rs should outlive the process. I don't see any benefits a systemd unit would add

@cgwalters
Copy link
Contributor

Obviously up to you! The reason I commented here is because pid files are IMO a code smell; anywhere one has a pid file a systemd unit would be more reliable. Specifically reading pid files and invoking kill() on them is inherently racy with the process crashing and pid reuse etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants