Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Add support for "buildx build --push" and/or "buildx build --output=type=registry" #4671

Open
matskiv opened this issue Feb 2, 2023 · 14 comments · May be fixed by #4677
Open

[Feature]: Add support for "buildx build --push" and/or "buildx build --output=type=registry" #4671

matskiv opened this issue Feb 2, 2023 · 14 comments · May be fixed by #4677
Assignees
@matskiv @danishprakash
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/feature Categorizes issue or PR as related to a new feature. stale-issue

Comments

@matskiv
Copy link

matskiv commented Feb 2, 2023

Feature request description

Please add support for the "buildx build --push" and/or "buildx build --output=type=registry" flags which would ensure that the built image is pushed to the registry. According to the buildx reference, the --push flag is just shorthand for --output=type=registry. So IMHO implementing both these things would be ideal, but I will be happy with either one.

Suggest potential solution

A clear and concise description of what you want to happen.

Have you considered any alternatives?

When using the CLI manually, I can of course use a separate command to push the image, this feature would help in integration with other tools - I am using DevSpace CLI tool which, in some cases, calls docker build build via CLI, and it relies on the --push flag. And so far this is the only compatibility problem that I found when using podman(with podman-docker).

Additional context

I may be able to contribute a PR if you think this is not to complex, and can give me a couple of pointers in the right direction. :)
@matskiv matskiv added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 2, 2023
@rhatdan
Copy link
Member

rhatdan commented Feb 3, 2023

Would love to get a commit from you.
You should be able to do most of this in
cmd/podman/images/build.go and buildx.go

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

A friendly reminder that this issue had no activity for 30 days.

@rhatdan rhatdan added Good First Issue This issue would be a good issue for a first time contributor to undertake. and removed stale-issue labels Mar 6, 2023
@rhatdan
Copy link
Member

rhatdan commented Mar 6, 2023

@flouthoc got some time to look at this?

@flouthoc
Copy link
Collaborator

flouthoc commented Mar 6, 2023

I'll take a look at this.

@danishprakash
Copy link
Contributor

@flouthoc If you haven't started already, I'd like to take a shot at this.

@flouthoc
Copy link
Collaborator

@danishprakash Sure feel free to take it.

@flouthoc
Copy link
Collaborator

@danishprakash In case if you go short on time, feel free to assign it back to me anytime :)

@danishprakash
Copy link
Contributor

You should be able to do most of this in
cmd/podman/images/build.go and buildx.go

Just starting here but shouldn't this be moved to containers/buildah given the actual changes would be made there and perhaps the flags to be moved here once that's done? Or am I missing something?

@rhatdan rhatdan transferred this issue from containers/podman Mar 17, 2023
@danishprakash danishprakash linked a pull request Mar 21, 2023 that will close this issue
Open
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Apr 21, 2023

@danishprakash @flouthoc What is the state of this one?

@danishprakash
Copy link
Contributor

Could you take a look at some of my comments on the PR for this? Whenever you've a moment, thanks!

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@flouthoc
Copy link
Collaborator

Being Implemented here: #4677

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@flouthoc flouthoc mentioned this issue Sep 18, 2023
Closed
@uhthomas uhthomas mentioned this issue Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matskiv matskiv

@danishprakash danishprakash

Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/feature Categorizes issue or PR as related to a new feature. stale-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd/build: add support for --push danishprakash/buildah
4 participants
@matskiv @rhatdan @flouthoc @danishprakash