-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add group_add parameter for podman quadlet #827
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshnaidm
requested changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contribution, comment is inside
Co-authored-by: Sergey <[email protected]>
sshnaidm
approved these changes
Sep 2, 2024
Thanks for fixing! |
tompre
added a commit
to tompre/ansible-podman-collections
that referenced
this pull request
Sep 22, 2024
This reverts commit 4f24ece.
8 tasks
tompre
added a commit
to tompre/ansible-podman-collections
that referenced
this pull request
Sep 22, 2024
This reverts commit 4f24ece. Signed-off-by: Thomas Preindl <[email protected]>
sshnaidm
pushed a commit
that referenced
this pull request
Oct 6, 2024
* Revert "Add group_add parameter for podman quadlet (#827)" This reverts commit 4f24ece. Signed-off-by: Thomas Preindl <[email protected]> * Add 'group_add' to 'GroupAdd' parameter mapping for podman container quadlet Signed-off-by: Thomas Preindl <[email protected]> * Add 'cgroups' to 'CgroupsMode' parameter mapping for podman container quadlet Signed-off-by: Thomas Preindl <[email protected]> * Fix 'etc_hosts' to 'AddHost' parameter mapping for podman container quadlet Signed-off-by: Thomas Preindl <[email protected]> * Fix 'network_aliases' to 'NetworkAlias' parameter mapping for podman container quadlet Signed-off-by: Thomas Preindl <[email protected]> * Fix 'stop_signal' to 'StopSignal' parameter mapping for podman container quadlet Signed-off-by: Thomas Preindl <[email protected]> * Add 'cpus' parameter mapping for podman container quadlet Signed-off-by: Thomas Preindl <[email protected]> * Add 'platform' parameter mapping for podman container quadlet Signed-off-by: Thomas Preindl <[email protected]> * Add 'log_opt' to 'LogOpt' parameter mapping for podman container quadlet Signed-off-by: Thomas Preindl <[email protected]> --------- Signed-off-by: Thomas Preindl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group_add parameter is not propagated to the container file at the moment.
This pull request adds the feature.