Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add group_add parameter for podman quadlet #827

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

tompre
Copy link
Contributor

@tompre tompre commented Aug 22, 2024

The group_add parameter is not propagated to the container file at the moment.

This pull request adds the feature.

Copy link
Member

@sshnaidm sshnaidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution, comment is inside

plugins/module_utils/podman/quadlet.py Outdated Show resolved Hide resolved
@sshnaidm
Copy link
Member

sshnaidm commented Sep 2, 2024

Thanks for fixing!

@sshnaidm sshnaidm merged commit 4f24ece into containers:master Sep 2, 2024
20 checks passed
tompre added a commit to tompre/ansible-podman-collections that referenced this pull request Sep 22, 2024
tompre added a commit to tompre/ansible-podman-collections that referenced this pull request Sep 22, 2024
@tompre tompre deleted the patch-1 branch September 22, 2024 21:43
sshnaidm pushed a commit that referenced this pull request Oct 6, 2024
* Revert "Add group_add parameter for podman quadlet (#827)"

This reverts commit 4f24ece.

Signed-off-by: Thomas Preindl <[email protected]>

* Add 'group_add' to 'GroupAdd' parameter mapping for podman container quadlet

Signed-off-by: Thomas Preindl <[email protected]>

* Add 'cgroups' to 'CgroupsMode' parameter mapping for podman container quadlet

Signed-off-by: Thomas Preindl <[email protected]>

* Fix 'etc_hosts' to 'AddHost' parameter mapping for podman container quadlet

Signed-off-by: Thomas Preindl <[email protected]>

* Fix 'network_aliases' to 'NetworkAlias' parameter mapping for podman container quadlet

Signed-off-by: Thomas Preindl <[email protected]>

* Fix 'stop_signal' to 'StopSignal' parameter mapping for podman container quadlet

Signed-off-by: Thomas Preindl <[email protected]>

* Add 'cpus' parameter mapping for podman container quadlet

Signed-off-by: Thomas Preindl <[email protected]>

* Add 'platform' parameter mapping for podman container quadlet

Signed-off-by: Thomas Preindl <[email protected]>

* Add 'log_opt' to 'LogOpt' parameter mapping for podman container quadlet

Signed-off-by: Thomas Preindl <[email protected]>

---------

Signed-off-by: Thomas Preindl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants