-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
podman_load image is not idempotent (?) #845
Comments
@DavidJaeck yes, it's not idempotent, since Podman always loads the image and doesn't provide any indication whether it's already loaded or not. Probably it even can't say without loading it 🤷 We can't do here anything, unless you have ideas how to do it. |
@sshnaidm I can confirm there is an issue with
|
@DavidJaeck sorry, I'm not sure what you mean. Can you elaborate please? |
The cmd stderr for So there is an issue with subprocess.run |
@DavidJaeck OK, but how is it related to idempotency? Firstly, the blob is not the image, it's fine to have existing blobs when you are loading the completely new image. The output still doesn't tell you if it was there before or not. |
Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Description
I am not sure if this is a bug, or if I am using the module incorrectly.
I am loading an image with podman_load.
The load is successful, however the changed when status and sdt error lines seem incorrect.
If I import the image twice I would expect the status to be "changed": false and I would expect the error line to state blobs are skipped because they already exist. However there always appears to be a change since the module is never realizing the blobs are already existent and can be skipped.
Steps to reproduce the issue:
ansible-playbook testplaybook.yml
with file content
hosts: localhost
tasks:
containers.podman.podman_load:
input: eclipse-mosquitto-2.0.18.tar
ansible-playbook testplaybook.yml
Describe the results you received:
I receive status "changed": true
and stderror lines
Describe the results you expected:
I receive "changed": false
and sdterror lines along the lines of
Additional information you deem important (e.g. issue happens only occasionally):
Version of the
containers.podman
collection:Either git commit if installed from git:
git show --summary
Or version from
ansible-galaxy
if installed from galaxy:ansible-galaxy collection list | grep containers.podman
Output of
ansible --version
:Output of
podman version
:Output of
podman info --debug
:Package info (e.g. output of
rpm -q podman
orapt list podman
):Playbok you run with ansible (e.g. content of
playbook.yaml
):Command line and output of ansible run with high verbosity
Please NOTE: if you submit a bug about idempotency, run the playbook with
--diff
option, like:ansible-playbook -i inventory --diff -vv playbook.yml
Additional environment details (AWS, VirtualBox, physical, etc.):
physical
The text was updated successfully, but these errors were encountered: