Revisit Registry Authentication #212
Labels
enhancement
New feature or request
needs-triage
This label refers to a non-final decision on implementation, when an important feature/bug is added
P1
P1 label is used for this that we see of highest priority. Critical bugs, security issues, etc
Security
Security enhancement related work
Milestone
It's been a while since we revisited our authentication/authorisation flow (which we should do as soon as we can). This ticket is going to act like a spike/research placeholder. Let's prepare a diagram of the entire flow.
Also probably a good idea to close this issue out and migrate all the work over here?
#13
When doing some work, today I realised that we've been comparing the wrong values inside our
BasicAuth
middleware:From
main
:https://github.com/containerish/OpenRegistry/blob/main/auth/basic_auth.go#L50
This line tries to compare like
Request URI is always in the follow this pattern -
<host>:<port>/<path>
What we need to do here is:
Same is true for https://github.com/containerish/OpenRegistry/blob/main/auth/basic_auth.go#L56
While we're at it, probably do it the way official registry (https://github.com/distribution/distribution) does it?
Auth Interface - https://github.com/distribution/distribution/blob/main/registry/auth/auth.go
The text was updated successfully, but these errors were encountered: