change Message.ToString() to not change object state anymore #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue connamara#883 New function ConstructString now does the BodyLength/CheckSum update that ToString used to do
hlibman-connamara
pushed a commit
to hlibman-connamara/quickfixn
that referenced
this pull request
Dec 6, 2024
change Message.ToString() to not change object state anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #863
Change
Message.ToString()to not alter object state anymore (which breaks the inheritance guidelines of ToString().Moved the old functionality of computing/adding/updating BodyLength & CheckSum to the new function
Message.ConstructString().(I really thought this was going to be more trouble than it actually was!)