Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture inner exception messages when handling authentication exceptions #740

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

rars
Copy link
Contributor

@rars rars commented Aug 27, 2022

Often the helpful information is contained in the inner exception's message rather than the message of the AuthenticationException which often just says 'see inner exception'. This helps improve the log output to diagnose reasons for authentication failures.

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2022

CLA assistant check
All committers have signed the CLA.

@rars rars changed the title Capture inner exception messages when handling authention exceptions Capture inner exception messages when handling authentication exceptions Aug 27, 2022
@gbirchmeier gbirchmeier force-pushed the improve-authentication-error-log branch from 667d21a to d355ffb Compare February 13, 2024 17:15
@gbirchmeier
Copy link
Member

Thanks!

@gbirchmeier gbirchmeier merged commit e97b24a into connamara:master Feb 13, 2024
2 checks passed
hlibman-connamara pushed a commit to hlibman-connamara/quickfixn that referenced this pull request Dec 6, 2024
hlibman-connamara pushed a commit to hlibman-connamara/quickfixn that referenced this pull request Dec 6, 2024
…or-log

Capture inner exception messages when handling authentication exceptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants