-
Notifications
You must be signed in to change notification settings - Fork 563
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #888 from gbirchmeier/field-class-cleanup
cleanup/nullable-ize IField-derived classes
- Loading branch information
Showing
60 changed files
with
969 additions
and
1,114 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| #nullable enable | ||
| using System.Collections.Generic; | ||
| using System.Net; | ||
| using QuickFix.Logger; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,37 +1,19 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Text; | ||
| namespace QuickFix.Fields; | ||
|
|
||
| namespace QuickFix.Fields | ||
| { | ||
| /// <summary> | ||
| /// FIX BooleanField class | ||
| /// </summary> | ||
| public class BooleanField : FieldBase<Boolean> | ||
| { | ||
| public BooleanField(int tag) | ||
| : base(tag, false) { } | ||
|
|
||
| public BooleanField(int tag, Boolean b) | ||
| : base(tag, b) { } | ||
|
|
||
| /// <summary> | ||
| /// quickfix-cpp compat - returns base type | ||
| /// </summary> | ||
| /// <returns>Boolean object</returns> | ||
| public Boolean getValue() | ||
| { return Obj; } | ||
| /// <summary> | ||
| /// FIX Boolean field | ||
| /// </summary> | ||
| public class BooleanField : FieldBase<bool> { | ||
| public BooleanField(int tag) | ||
| : base(tag, false) { | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// quickfix-cpp compat - set object | ||
| /// </summary> | ||
| public void setValue(Boolean b) | ||
| { Obj = b; } | ||
| public BooleanField(int tag, bool b) | ||
| : base(tag, b) { | ||
| } | ||
|
|
||
| protected override string makeString() | ||
| { | ||
| return Converters.BoolConverter.Convert(Obj); | ||
| } | ||
| protected override string MakeString() { | ||
| return Converters.BoolConverter.Convert(Value); | ||
| } | ||
| } | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,18 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Text; | ||
| namespace QuickFix.Fields; | ||
|
|
||
| namespace QuickFix.Fields | ||
| { | ||
| /// <summary> | ||
| /// A character message field | ||
| /// </summary> | ||
| public class CharField : FieldBase<Char> | ||
| { | ||
| public CharField(int tag) | ||
| :base(tag, '\0') {} | ||
|
|
||
| public CharField(int tag, char c) | ||
| : base(tag, c) { } | ||
|
|
||
| // quickfix compat | ||
| public char getValue() | ||
| { return Obj; } | ||
| /// <summary> | ||
| /// FIX character field | ||
| /// </summary> | ||
| public class CharField : FieldBase<char> { | ||
| public CharField(int tag) | ||
| : base(tag, '\0') { | ||
| } | ||
|
|
||
| public void setValue(char c) | ||
| { Obj = c; } | ||
| public CharField(int tag, char c) | ||
| : base(tag, c) { | ||
| } | ||
|
|
||
| protected override string makeString() | ||
| { | ||
| return Converters.CharConverter.Convert(Obj); | ||
| } | ||
| protected override string MakeString() { | ||
| return Converters.CharConverter.Convert(Value); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| #nullable enable | ||
| using System; | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Globalization; | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.