-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support az-tdx-vtpm tee #169
Add support az-tdx-vtpm tee #169
Conversation
048c5bd
to
6046da8
Compare
b638fa6
to
aaf600c
Compare
aaf600c
to
9adf9e9
Compare
9adf9e9
to
efd2d6e
Compare
efd2d6e
to
32955e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR Magnus! There is a only problem that might cause unexpected behavior
if var_data_hash != td_quote.report_body.report_data[..32] { | ||
bail!("TDX Quote report data mismatch"); | ||
} | ||
debug!("Report data verification completed successfully."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the debug
check point here
15bd589
to
360a4eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. See one comment
- Added verification code - Added tdx fixtures and test cases - Reorganized snp fixtures - Added missing dependency for tdx e2e test - Added entry for e2e test Co-authored-by: Xynnn_ <xynnn@linux.alibaba.com> Signed-off-by: Magnus Kulke <magnuskulke@microsoft.com>
432acb4
to
689a11c
Compare
This is a tracking issue for adding the
az-tdx-vtpm
tee that is required to add support for Azure's TDX CVMs to CoCo.Related PRs
e2e Test
The test performs a key release via remote-attestation using the
az-tdx-vtpm
tee. Build and run this PR on an Azure TDX CVM.Prepare
The steps assume Ubuntu 22.04:
Run tests
Install rust + golang