From b9679f05fafc5dea84100c42cad9a290cf4a29a7 Mon Sep 17 00:00:00 2001 From: stevenhorsman Date: Wed, 11 Dec 2024 11:45:27 +0000 Subject: [PATCH] tests/e2e: libivrt: Unskip tests Unskipping the previously flakey libvirt tests. We've had some code fixes in kata and environmental changes that might have helped improve the stability of these tests. Signed-off-by: stevenhorsman --- .../test/e2e/libvirt_test.go | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/src/cloud-api-adaptor/test/e2e/libvirt_test.go b/src/cloud-api-adaptor/test/e2e/libvirt_test.go index 0f08ec288..4a3b33b8f 100644 --- a/src/cloud-api-adaptor/test/e2e/libvirt_test.go +++ b/src/cloud-api-adaptor/test/e2e/libvirt_test.go @@ -19,7 +19,6 @@ func TestLibvirtCreateSimplePod(t *testing.T) { } func TestLibvirtCreatePodWithConfigMap(t *testing.T) { - SkipTestOnCI(t) assert := LibvirtAssert{} DoTestCreatePodWithConfigMap(t, testEnv, assert) } @@ -62,25 +61,16 @@ func TestLibvirtCreatePeerPodAndCheckUserLogs(t *testing.T) { } func TestLibvirtCreatePeerPodAndCheckWorkDirLogs(t *testing.T) { - // This test is causing issues on CI with instability, so skip until we can resolve this. - // See https://github.com/confidential-containers/cloud-api-adaptor/issues/1831 - SkipTestOnCI(t) assert := LibvirtAssert{} DoTestCreatePeerPodAndCheckWorkDirLogs(t, testEnv, assert) } func TestLibvirtCreatePeerPodAndCheckEnvVariableLogsWithImageOnly(t *testing.T) { - // This test is causing issues on CI with instability, so skip until we can resolve this. - // See https://github.com/confidential-containers/cloud-api-adaptor/issues/1831 - SkipTestOnCI(t) assert := LibvirtAssert{} DoTestCreatePeerPodAndCheckEnvVariableLogsWithImageOnly(t, testEnv, assert) } func TestLibvirtCreatePeerPodAndCheckEnvVariableLogsWithDeploymentOnly(t *testing.T) { - // This test is causing issues on CI with instability, so skip until we can resolve this. - // See https://github.com/confidential-containers/cloud-api-adaptor/issues/1831 - SkipTestOnCI(t) assert := LibvirtAssert{} DoTestCreatePeerPodAndCheckEnvVariableLogsWithDeploymentOnly(t, testEnv, assert) } @@ -94,20 +84,15 @@ func TestLibvirtCreatePeerPodAndCheckEnvVariableLogsWithImageAndDeployment(t *te } func TestLibvirtCreateNginxDeployment(t *testing.T) { - // This test is causing issues on CI with instability, so skip until we can resolve this. - // See https://github.com/confidential-containers/cloud-api-adaptor/issues/2046 - SkipTestOnCI(t) assert := LibvirtAssert{} DoTestNginxDeployment(t, testEnv, assert) } -/* -Failing due to issues will pulling image (ErrImagePull) func TestLibvirtCreatePeerPodWithLargeImage(t *testing.T) { + SkipTestOnCI(t) assert := LibvirtAssert{} DoTestCreatePeerPodWithLargeImage(t, testEnv, assert) } -*/ func TestLibvirtDeletePod(t *testing.T) { assert := LibvirtAssert{} @@ -116,7 +101,6 @@ func TestLibvirtDeletePod(t *testing.T) { func TestLibvirtPodToServiceCommunication(t *testing.T) { // This test is causing issues on CI with instability, so skip until we can resolve this. - SkipTestOnCI(t) if isTestOnCrio() { t.Skip("Fails with CRI-O (confidential-containers/cloud-api-adaptor#2100)") } @@ -126,7 +110,6 @@ func TestLibvirtPodToServiceCommunication(t *testing.T) { func TestLibvirtPodsMTLSCommunication(t *testing.T) { // This test is causing issues on CI with instability, so skip until we can resolve this. - SkipTestOnCI(t) if isTestOnCrio() { t.Skip("Fails with CRI-O (confidential-containers/cloud-api-adaptor#2100)") }