Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with conda-forge #53

Open
rth opened this issue Nov 14, 2019 · 4 comments
Open

Integration with conda-forge #53

rth opened this issue Nov 14, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request In progress Activity in progress

Comments

@rth
Copy link

rth commented Nov 14, 2019

Just wondering is there any plans to optionally run conda-press as part of conda-forge CI?

The issue is that as long as a separate CI needs to be setup for each platform (#40) the effort to build wheels (e.g. with the setup from https://github.com/MacPython) is not that much higher than setting up CI for conda-press (well at least for not too complicated projects).

To run it as part of conda-forge I imagine it would be necessary to change the CI scripts and add some optional flag to meta.yaml.

Then wheels need to be uploaded somewhere: maybe an S3 bucket or possibly we could use the same account (different bucket) that is provided for free by Rackspace for the wheels built in MacPython org.

Another point is that conda-press might need to be adapted to work for locally built packages that are not yet uploaded to a conda channel.

@marcelotrevisani
Copy link
Member

marcelotrevisani commented Nov 14, 2019

Hi @rth ,
We do have some plans do integrate it with conda-forge.
I was working on it, I stopped a bit just to work on pytest-replay and to add some infra in conda-build which I saw more urgency let's say.
But I will get it right after it. It is on my to-do list. I just need to add one more functionality to conda-press to recursively get the conda packages and after that, the integration with conda-smithy will be easy and we can optionally add it.

The original idea was to add a conda-press.yaml on the feedstock root, if it is present it will run conda-press with the options in there, we can also develop some features to upload it somewhere (I didn't think that carefully yet).

I just did some very simple tests in this PR (that is just for Linux):
conda-forge/conda-press-feedstock#7

@marcelotrevisani marcelotrevisani self-assigned this Nov 14, 2019
@marcelotrevisani marcelotrevisani added enhancement New feature or request In progress Activity in progress labels Nov 14, 2019
@marcelotrevisani
Copy link
Member

Just regarding the last part

Another point is that conda-press might need to be adapted to work for locally built packages that are not yet uploaded to a conda channel.

What do you mean?
The dependencies? Because you can convert it locally, you just have to pass the path to the conda package

@rth
Copy link
Author

rth commented Nov 14, 2019

Great, good to know @marcelotrevisani !

Just regarding the last part

It was a guess, I am not too familiar with conda-press internals, ignore it if you think it's not relevant :)

@scopatz
Copy link
Contributor

scopatz commented Nov 14, 2019

Also, @rth, anyone is welcome to help out with this 😉 @marcelotrevisani has done an amazing job of helping get us going on the feedstocks CI, but more hands are always welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request In progress Activity in progress
Projects
None yet
Development

No branches or pull requests

3 participants