Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #126

Open
sameeul opened this issue Oct 24, 2024 · 7 comments
Open

Windows support #126

sameeul opened this issue Oct 24, 2024 · 7 comments
Labels
question Further information is requested

Comments

@sameeul
Copy link

sameeul commented Oct 24, 2024

Comment:

Hi, I am curious why the recipe skips Windows build. I see that there are PyPI wheels for windows, so I am curious to know what technical difficulty is preventing us from building a Windows package for conda.

I have a downstream project that depends on this package (via transitive dependency). I am also open to help to get the Windows package build.

@sameeul sameeul added the question Further information is requested label Oct 24, 2024
@mr-c
Copy link
Contributor

mr-c commented Oct 24, 2024

Hello @sameeul ; can you share more about this dependency tree that include schema-salad?

There are no binary wheels for schema-salad on PyPI, just a source wheel: https://pypi.org/project/schema-salad/8.7.20241021092521/#files

@sameeul
Copy link
Author

sameeul commented Oct 24, 2024

We are working on creating a recipe for this package (https://github.com/PolusAI/workflow-inference-compiler/). It uses cwl-utils and that brings schema-salad as a dependency.

@mr-c
Copy link
Contributor

mr-c commented Oct 24, 2024

As an experiment, I am attempting to build a binary wheel for MS Windows at common-workflow-language/schema_salad#887

See https://github.com/common-workflow-language/schema_salad/actions/runs/11498282467/job/32003751500?pr=887

@mr-c
Copy link
Contributor

mr-c commented Oct 24, 2024

@sameeul Note that cwltool does not support running in MS Windows, but it is supported inside WSL2: https://cwltool.readthedocs.io/en/latest/#ms-windows-users

@sameeul
Copy link
Author

sameeul commented Oct 24, 2024

Yes, we are aware of it. We are also developing another "compute" tool that can take CWL workflows generated by this tool and can run in various compute environment (e.g.. on HPC using toil, on Nix systems using cwltool, and in AWS EC2 using argo)

@mr-c
Copy link
Contributor

mr-c commented Oct 24, 2024

@sameeul The schema-salad tests don't currently pass on MS Windows; that is probably fixable. Can you contribute a PR?

https://github.com/common-workflow-language/schema_salad/actions/runs/11499085946/job/32006276340?pr=887

@sameeul
Copy link
Author

sameeul commented Oct 24, 2024

Sure. I will take a stab at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants