Should bash completion be auto-activated ?

[phil-blain]

I see in

git-feedstock/recipe/build.sh

Lines 38 to 40 in 4b1de47

	# Install completion files
	mkdir -p $PREFIX/share/bash-completion/completions
	cp contrib/completion/git-completion.bash $PREFIX/share/bash-completion/completions/git

that the bash-completion script in installed to $CONDA_PREFIX/share/bash-completion/completions/git.

Should this script also be added to ${PREFIX}/etc/conda/activate.d/ so that it is automatically sourced when the environment is activated ?
I think that would be a great addition and I'd be happy to submit a PR for that.

Reference: https://docs.conda.io/projects/conda-build/en/latest/resources/activate-scripts.html

[jakirkham]

Agree this would be great.

That said, let's think through this a bit. Would it interfere with already active bash completion? Would this only gets run in the bash shell or would it run in other shells? If the latter, how can we protect against sourcing this in the wrong shell?

Thoughts from others?

cc @conda-forge/git

[asmeurer]

Isn't that a general problem for activate scripts. Presumably there is a way to only source for the right shell.

git has completion for bash, zsh, and tsch.

As for if it's already enabled, it looks like it should work to check if __git_complete is already defined.