git package redistrubutes some Microsoft copyrighted files + git post install script partially fails + bash stdin stdout files test fails

[kiwi0fruit]

• This git package redistrubutes some Microsoft copyrighted files. This happen because of the git post install script (that should be run on user machine only!) copying some Windows files.
• Git post install script invoked the wrong way. The file says that it should be:

   git-bash.exe --no-needs-console --hide --no-cd --command=post-install.bat

• But fixing it doesn's fix some unknown errors in the post install script. So that conda build fails if used this way:

  git-bash.exe --no-needs-console --hide --no-cd --command=post-install.bat || exit 1

  or this way:

  call post-install.bat || exit 1

Actually this package does redistribution the wrong way. The right way is to do literally the same as original git devs intended. So I suggest go with no_link and run post-install on the user machine.

[kiwi0fruit]

These issues were fixed in this conda package: https://github.com/kiwi0fruit/py-bash/tree/master/conda-forge/git-bash

[scopatz]

So should we close this?

[kiwi0fruit]

This package still:

1. redistributes a few files copied from Windows that have Microsoft copyright hats.
2. doesn't pass this test: bash -c "if [[ $(echo hello | cp /dev/stdin /dev/stdout) != 'hello' ]]; then exit 1; fi" because post install script should run on user machine not on build machine.

I'd rather see this issue #53 resolved (maybe even in favor of being the same as in main channel) as this is just you know ugly.

[scopatz]

OK - @kiwi0fruit, I am unclear why (1) is a problem, as long as they have open source licenses

[kiwi0fruit]

Hm, it's not clear what license they have. I don't remember them being open source. If I remember correctly they are proprietary (but that needs checking).

[scopatz]

If they are modifying git, then they'd be GPL

[kiwi0fruit]

They are simply files copied from C:\Windows...

[scopatz]

Ahh that is not great.

[kiwi0fruit]

Sorry for I cannot check this now as I'm not near PC. So this is all I remember now. I didn't paid this much attention as I decided to run post-install script on user machine (in git-bash package) as there are other bugs otherwise. So it should not be a problem in this case. I guess...

[kiwi0fruit]

But there is really something minor. Like current machine hosts with copyrighted commented examples and the only trivial working line.

[kiwi0fruit]

Current version of conda-forge::git still fails this test on Windows:

bash -c "if [[ $(echo hello | cp /dev/stdin /dev/stdout) != 'hello' ]]; then exit 1; fi"

While installer-installed git-bash passes it OK.