Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inputNumberPolyfill assumes type attribute is there (and can crash) #4

Open
bbottema opened this issue Jul 15, 2016 · 0 comments
Open

inputNumberPolyfill assumes type attribute is there (and can crash) #4

bbottema opened this issue Jul 15, 2016 · 0 comments

Comments

@bbottema
Copy link

inputNumberPolyfill should not assume anything about inputs and only apply itself when it can, but never error out.

return elem.attr("type").toLowerCase() === "number" && (...)

Should become:

return elem.attr("type") && elem.attr("type").toLowerCase() === "number" &&
@bbottema bbottema changed the title inputNumberPolyfill assumes type attribute is there inputNumberPolyfill assumes type attribute is there (and can crash) Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bbottema