fix: failfast if LIBRARY_ROOT is not set

deploy/conf/.env.template

@@ -8,39 +8,28 @@ DB_NAME=comsesnet
 DB_USER=comsesnet
 DB_HOST=db
 DB_PORT=5432
-DB_PASSWORD=
 CLEAN_DATABASE="false"  # allowed values: "true" or "false"
 
 # elastic search
 ES_VERSION=7.17.18
 
 # captcha
 HCAPTCHA_SITEKEY=
-# HCAPTCHA_SECRET=
 
 # discourse
 DISCOURSE_BASE_URL=
 DISCOURSE_API_USERNAME=
 
 # email
 EMAIL_SUBJECT_PREFIX=[CoMSES Net]
-# MAILGUN_API_KEY=
 MAILGUN_SENDER_DOMAIN=
 
 # logging
 LOG_DIRECTORY=/shared/logs
 SENTRY_DSN=
 
-# secrets
-# DISCOURSE_SSO_SECRET=
-# DISCOURSE_API_KEY=
-# django secret key
-# SECRET_KEY=
-
 GITHUB_CLIENT_ID=
-# GITHUB_CLIENT_SECRET=
 ORCID_CLIENT_ID=
-# ORCID_CLIENT_SECRET=
 
 # storage
 DATA_ROOT=/shared

django/core/settings/defaults.py

@@ -286,9 +286,11 @@ def is_test(self):
 
 SHARE_DIR = "/shared"
 LOG_DIRECTORY = os.getenv("LOG_DIRECTORY", os.path.join(BASE_DIR, "logs"))
-LIBRARY_ROOT = os.getenv("LIBRARY_ROOT", os.path.join(BASE_DIR, "library"))
+LIBRARY_ROOT = os.getenv("LIBRARY_ROOT")
+if not LIBRARY_ROOT:
+    raise ValueError("LIBRARY_ROOT not configured")
 PREVIOUS_SHARE_ROOT = os.path.join(SHARE_DIR, ".latest")
-REPOSITORY_ROOT = os.getenv("REPOSITORY_ROOT", os.path.join(BASE_DIR, "repository"))
+REPOSITORY_ROOT = os.getenv("REPOSITORY_ROOT")
 BORG_ROOT = "/shared/backups/repo"
 BACKUP_ROOT = "/shared/backups"
 EXTRACT_ROOT = "/shared/extract"

django/deploy/cron.daily/backup

@@ -1,4 +1,4 @@
 #!/bin/sh
 
 export DJANGO_SETTINGS_MODULE="core.settings.production"
-/usr/local/bin/inv -r /code db.backup borg.backup > /var/log/comses-backup.log 2>&1
+/usr/local/bin/inv -r /code db.backup borg.backup >> /shared/logs/comses-backup.log 2>&1