-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JuliaFormatter #390
Merged
Merged
Use JuliaFormatter #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willtebbutt
reviewed
Nov 24, 2024
willtebbutt
reviewed
Nov 24, 2024
Thanks for doing this. I know there aren't going to be any semantic changes, but could we bump the patch anyway please? |
Done |
@gdalle if you're happy for this to get merged, please mark as ready for review, and I'll approve and merge. |
Let's do this. The codecov impact is inevitable because we modified the total number of lines and how they're distributed |
willtebbutt
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #388
This PR has no semantic impact on the code, the last commit is just massive because I formatted the whole repo.
The only meaningful additions are a JuliaFormatter style file and test.