Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JuliaFormatter #390

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Use JuliaFormatter #390

merged 4 commits into from
Nov 25, 2024

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented Nov 24, 2024

Fixes #388

This PR has no semantic impact on the code, the last commit is just massive because I formatted the whole repo.

The only meaningful additions are a JuliaFormatter style file and test.

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 90.18303% with 59 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/rrules/array_legacy.jl 53.84% 12 Missing ⚠️
src/test_utils.jl 84.37% 10 Missing ⚠️
src/interpreter/s2s_reverse_mode_ad.jl 86.79% 7 Missing ⚠️
src/tangents.jl 90.16% 6 Missing ⚠️
src/rrules/blas.jl 93.93% 4 Missing ⚠️
src/interpreter/bbcode.jl 90.90% 3 Missing ⚠️
src/rrules/new.jl 57.14% 3 Missing ⚠️
src/interpreter/abstract_interpretation.jl 80.00% 2 Missing ⚠️
src/interpreter/ir_normalisation.jl 92.30% 2 Missing ⚠️
src/rrules/foreigncall.jl 66.66% 2 Missing ⚠️
... and 7 more
Files with missing lines Coverage Δ
ext/MooncakeAllocCheckExt.jl 100.00% <100.00%> (ø)
ext/MooncakeLuxLibSLEEFPiratesExtension.jl 100.00% <100.00%> (ø)
src/Mooncake.jl 100.00% <ø> (ø)
src/codual.jl 94.11% <100.00%> (ø)
src/config.jl 100.00% <100.00%> (ø)
src/debug_mode.jl 100.00% <100.00%> (ø)
src/developer_tools.jl 100.00% <ø> (ø)
src/interface.jl 91.66% <100.00%> (ø)
src/interpreter/ir_utils.jl 87.50% <100.00%> (ø)
src/interpreter/zero_like_rdata.jl 100.00% <100.00%> (ø)
... and 28 more

🚨 Try these New Features:

test/runtests.jl Outdated Show resolved Hide resolved
@willtebbutt
Copy link
Member

Thanks for doing this. I know there aren't going to be any semantic changes, but could we bump the patch anyway please?

@gdalle
Copy link
Collaborator Author

gdalle commented Nov 24, 2024

Done

@willtebbutt
Copy link
Member

@gdalle if you're happy for this to get merged, please mark as ready for review, and I'll approve and merge.

@gdalle gdalle marked this pull request as ready for review November 25, 2024 08:48
@gdalle
Copy link
Collaborator Author

gdalle commented Nov 25, 2024

Let's do this. The codecov impact is inevitable because we modified the total number of lines and how they're distributed

@willtebbutt willtebbutt merged commit d9a6952 into compintell:main Nov 25, 2024
72 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using JuliaFormatter?
2 participants