Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust include path search according to dependencies #175

Open
anutosh491 opened this issue Nov 15, 2024 · 1 comment · May be fixed by #187
Open

Adjust include path search according to dependencies #175

anutosh491 opened this issue Nov 15, 2024 · 1 comment · May be fixed by #187
Labels
good first issue Good for newcomers

Comments

@anutosh491
Copy link
Collaborator

If xeus and its dependencies are installed in non standard location, xeus-cpp needs to be aware of the related include directories to be able to process xcpp extensions correctly.

I think this needs to be addressed as it was done for xeus-cling

  1. https://github.com/jupyter-xeus/xeus-cling/blob/93d61b98518c494fc0e195844c392fc0d40dd0d2/src/xinterpreter.cpp#L435
  2. https://github.com/jupyter-xeus/xeus-cling/blob/93d61b98518c494fc0e195844c392fc0d40dd0d2/CMakeLists.txt#L332-L333
@anutosh491 anutosh491 added the good first issue Good for newcomers label Nov 15, 2024
@github-actions github-actions bot added the Needs triage Used in auto labelling of new issues label Nov 15, 2024
@AhmedFatthy1040 AhmedFatthy1040 linked a pull request Nov 28, 2024 that will close this issue
Open
4 tasks
@AhmedFatthy1040
Copy link

AhmedFatthy1040 commented Nov 28, 2024 •
edited
Loading

I’ve submitted a PR addressing this issue. #187
Please take a look and let me know if there are any further adjustments needed. 😊
Thanks!

AhmedFatthy1040 added a commit to AhmedFatthy1040/xeus-cpp that referenced this issue Dec 3, 2024
@AhmedFatthy1040
Switch XEUS_SEARCH_PATH from compile-time to runtime
71cd1ec 
This change:
1. Replaces compile-time XEUS_SEARCH_PATH define with runtime environment variable
2. Removes CMake definition to eliminate redefinition warnings
3. Adds test to verify non-standard include path functionality
4. Makes include path configuration more flexible (can be changed without recompiling)

Resolves compiler-research#175
@mcbarton mcbarton removed the Needs triage Used in auto labelling of new issues label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@anutosh491 @AhmedFatthy1040 @mcbarton