From fbe98886750ad54b69c27e0ee73272f8d0aa22bf Mon Sep 17 00:00:00 2001
From: Aaron  Jomy <75925957+aaronj0@users.noreply.github.com>
Date: Thu, 19 Sep 2024 15:33:42 +0200
Subject: [PATCH] [ci] Update the CI to follow other repositories in running
 valgrind

This was never updated on the backend repo and lags the other repos. This should fix the current failures in the CI on master
---
 .github/workflows/ci.yml | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index b9bd7bff..c0f86789 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -720,13 +720,10 @@ jobs:
         if [[ "${{ matrix.os }}" == macos-* ]]; then
         echo "Skipping Valgrind checks on macOS"
         else
-            if [[ "${{ matrix.clang-runtime }}" == "17" ]]; then
-                echo "Valgrind reports true for clang-runtime 17, due to memory leaks with LLVM"
-                valgrind --show-error-list=yes --error-exitcode=1 --suppressions=../etc/valgrind-cppyy-cling.supp python -m pytest -m "not xfail" -v || true
-            else
-                echo "Running valgrind on passing tests"
-                valgrind --show-error-list=yes --error-exitcode=1 --suppressions=../etc/valgrind-cppyy-cling.supp python -m pytest -m "not xfail" -v
-            fi
+            echo "Running valgrind on passing tests"
+            CLANG_VERSION="${{ matrix.clang-runtime }}"
+            SUPPRESSION_FILE="../etc/clang${CLANG_VERSION}-valgrind.supp"
+            valgrind --show-error-list=yes --error-exitcode=1 --track-origins=yes --suppressions="${SUPPRESSION_FILE}" --suppressions=../etc/valgrind-cppyy-cling.supp python -m pytest -m "not xfail" -v
         fi
         export RETCODE=+$?
         echo ::endgroup::