From 0093e32a1cdebf03a25015dbaa2aa20c098c9846 Mon Sep 17 00:00:00 2001 From: Aaron Jomy <75925957+maximusron@users.noreply.github.com> Date: Sat, 27 Apr 2024 11:00:22 +0200 Subject: [PATCH] [ci] Skip valgrind checks on OS X --- .github/workflows/ci.yml | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8933f9c3..b7e77bcf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -752,12 +752,16 @@ jobs: declare -i RETCODE=0 set -o pipefail - if [[ "${{ matrix.clang-runtime }}" == "17" || "${{ matrix.clang-runtime }}" == "18" ]] && [[ "${{ matrix.os }}" != "macos-14" ]]; then - echo "Valgrind reports true for clang-runtime 17 or 18, due to memory leaks with LLVM" - valgrind --error-exitcode=1 --suppressions=../etc/valgrind-cppyy-cling.supp python -m pytest -m "not xfail" -v || true + if [[ "${{ matrix.os }}" == macos-* ]]; then + echo "Skipping Valgrind checks on macOS" else - echo "Running valgrind on passing tests" - valgrind --error-exitcode=1 --suppressions=../etc/valgrind-cppyy-cling.supp python -m pytest -m "not xfail" -v + if [[ "${{ matrix.clang-runtime }}" == "17" || "${{ matrix.clang-runtime }}" == "18" ]]; then + echo "Valgrind reports true for clang-runtime 17 or 18, due to memory leaks with LLVM" + valgrind --error-exitcode=1 --suppressions=../etc/valgrind-cppyy-cling.supp python -m pytest -m "not xfail" -v || true + else + echo "Running valgrind on passing tests" + valgrind --error-exitcode=1 --suppressions=../etc/valgrind-cppyy-cling.supp python -m pytest -m "not xfail" -v + fi fi export RETCODE=+$? echo ::endgroup::