Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix developer documentation deployment #372

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Dec 4, 2024

@vgvassilev This PR may or may not provide a fix for #243 . It fixes the link on my local machine, but that may not necessarily work when deployed.

@mcbarton mcbarton requested a review from vgvassilev December 4, 2024 22:16
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.31%. Comparing base (111d0e5) to head (ead05e7).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   76.31%   76.31%           
=======================================
  Files           8        8           
  Lines        3137     3137           
=======================================
  Hits         2394     2394           
  Misses        743      743           

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@mcbarton mcbarton merged commit 4b8fbbc into compiler-research:main Dec 5, 2024
42 checks passed
@vgvassilev
Copy link
Contributor

@mcbarton, it seems this broke doxygen completely: https://cppinterop.readthedocs.io/en/latest/build/html/index.html

@mcbarton
Copy link
Collaborator Author

mcbarton commented Dec 5, 2024

@vgvassilev I'll put in a PR to revert the changes to .readthedocs.yaml and docs/conf.py since they will be the things that will have caused the breaking.

mcbarton added a commit to mcbarton/CppInterOp that referenced this pull request Dec 5, 2024
mcbarton added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants