Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add llvm 18 support #202

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Add llvm 18 support #202

merged 1 commit into from
Mar 11, 2024

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Mar 7, 2024

This PR adds Clang-18 to the CI now that it has been released.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.63%. Comparing base (bd72e91) to head (59e47db).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #202   +/-   ##
=======================================
  Coverage   78.63%   78.63%           
=======================================
  Files           8        8           
  Lines        3056     3057    +1     
=======================================
+ Hits         2403     2404    +1     
  Misses        653      653           
Files Coverage Δ
lib/Interpreter/DynamicLibraryManager.cpp 75.12% <100.00%> (ø)

... and 1 file with indirect coverage changes

Files Coverage Δ
lib/Interpreter/DynamicLibraryManager.cpp 75.12% <100.00%> (ø)

... and 1 file with indirect coverage changes

@mcbarton mcbarton marked this pull request as ready for review March 7, 2024 11:51
Copy link
Contributor

github-actions bot commented Mar 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

github-actions bot commented Mar 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton mcbarton changed the title Add Clang 18 to CI Add llvm 18 support Mar 7, 2024
@mcbarton
Copy link
Collaborator Author

mcbarton commented Mar 7, 2024

@vgvassilev This PR is ready for review.

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run git-clang-format HEAD~ to make the bot happy?

CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Mar 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

github-actions bot commented Mar 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton
Copy link
Collaborator Author

mcbarton commented Mar 7, 2024

@vgvassilev It is passing all checks now.

@mcbarton
Copy link
Collaborator Author

@alexander-penev can you review this PR for me please?

@vgvassilev
Copy link
Contributor

We will need to drop support for clang7. Our policy is to support the last 10 versions. That would require to clean up the ifdefs that mention clang 7.

@vgvassilev
Copy link
Contributor

Can you edit the commit message to something like:

Add support for clang18.

Fixes #805.

@mcbarton
Copy link
Collaborator Author

Can you edit the commit message to something like:

Add support for clang18.

Fixes #805.

I can change the commit message to "Add support for clang18" . We have no specific issue of support for clang 18 at the moment. I can create one and then add the fix message as you suggest.

@mcbarton
Copy link
Collaborator Author

We will need to drop support for clang7. Our policy is to support the last 10 versions. That would require to clean up the ifdefs that mention clang 7.

I will look for any ifdefs that mention clang 7 tomorrow and remove them.

@vgvassilev
Copy link
Contributor

Can you edit the commit message to something like:

Add support for clang18.

Fixes #805.

I can change the commit message to "Add support for clang18" . We have no specific issue of support for clang 18 at the moment. I can create one and then add the fix message as you suggest.

Dammit, no, I thought this is on the clad repository :(

@vgvassilev
Copy link
Contributor

We will need to drop support for clang7. Our policy is to support the last 10 versions. That would require to clean up the ifdefs that mention clang 7.

I will look for any ifdefs that mention clang 7 tomorrow and remove them.

Please ignore that comment...

@mcbarton
Copy link
Collaborator Author

mcbarton commented Mar 11, 2024

@vgvassilev @alexander-penev after this PR is reviewed and merged I am going to add a xeus-cpp build to the end of the wasm CppInterOp CI jobs. This will allow me/you to test possible changes to get the correct extension in compiler-research/xeus-cpp#14 . This will also help troubleshoot any other changes which may be needed.

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit 1334558 into compiler-research:main Mar 11, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants