Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cwltool:Loop extension definition #2081

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Fix cwltool:Loop extension definition #2081

merged 1 commit into from
Dec 12, 2024

Conversation

GlassOfWhiskey
Copy link
Contributor

This commit fixes two small errors in the cwltool:Loop definition that were breaking the Schema SALAD codegen procedure.

@GlassOfWhiskey GlassOfWhiskey requested a review from mr-c December 4, 2024 13:05
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.21%. Comparing base (604fd12) to head (2bcfdd4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2081      +/-   ##
==========================================
+ Coverage   84.20%   84.21%   +0.01%     
==========================================
  Files          46       46              
  Lines        8320     8320              
  Branches     1961     1961              
==========================================
+ Hits         7006     7007       +1     
+ Misses        838      836       -2     
- Partials      476      477       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GlassOfWhiskey GlassOfWhiskey force-pushed the fix-cwl-v1.2-extensions branch from 54f0087 to 1ecfaae Compare December 4, 2024 13:18
@mr-c
Copy link
Member

mr-c commented Dec 4, 2024

This commit fixes two small errors in the cwltool:Loop definition that were breaking the Schema SALAD codegen procedure.

What's the 2nd error?

@mr-c mr-c force-pushed the fix-cwl-v1.2-extensions branch from 1ecfaae to ade6f65 Compare December 10, 2024 12:43
@mr-c mr-c enabled auto-merge (squash) December 12, 2024 12:19
This commit fixes two small errors in the `cwltool:Loop` definition that
were breaking the Schema SALAD codegen procedure.
@mr-c mr-c force-pushed the fix-cwl-v1.2-extensions branch from ade6f65 to 2bcfdd4 Compare December 12, 2024 12:19
@mr-c mr-c merged commit d3c7bd5 into main Dec 12, 2024
9 of 13 checks passed
@mr-c mr-c deleted the fix-cwl-v1.2-extensions branch December 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants