-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove support for locale zh-CN #2988
base: main
Are you sure you want to change the base?
feat: remove support for locale zh-CN #2988
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: e446f40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 99 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
96099b0
to
9578eaa
Compare
9578eaa
to
970fb17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
970fb17
to
e446f40
Compare
"string": "小时:分钟" | ||
} | ||
} | ||
{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mustafaasif2 @tdeekens I decided to keep this file for now with empty data.
The reason being is that in App Kit's i18n
package the file is being referenced.
If we release UI Kit with the file removed, and App Kit is not updated to the latest version that removes the reference, there will be an error as the file is not found.
This way, we can release both UI Kit and App Kit independently without causing regressions.
Summary
Removed support for the Chinese locale (zh-CN) across UI Kit.
Description
Localization and translation support for the zh-CN locale are no longer needed in MC applications. This change removes all instances of zh-CN loading and support in UI Kit.